Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sysadvisor): numa balancer miss eviction #506

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

zzzzhhb
Copy link
Collaborator

@zzzzhhb zzzzhhb commented Mar 13, 2024

What type of PR is this?

Bug fixes

What this PR does / why we need it:

  1. fixs the bug that the pod will never be evicted when GetAdvice is called prior to GetEvictPods.
  2. don't skip the evicted pod when finding the balanced pod since eviction might not succeed.

Which issue(s) this PR fixes:

Special notes for your reviewer:

@zzzzhhb zzzzhhb added bug Something isn't working workflow/merge-ready merge-ready: code is ready and can be merged labels Mar 13, 2024
@zzzzhhb zzzzhhb self-assigned this Mar 13, 2024
@zzzzhhb zzzzhhb added workflow/merge-hold merge-hold: code is ready but still has dependency and removed workflow/merge-ready merge-ready: code is ready and can be merged labels Mar 13, 2024
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 55.13%. Comparing base (65db018) to head (af2ab76).

Files Patch % Lines
...qosaware/resource/memory/plugin/memory_balancer.go 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #506      +/-   ##
==========================================
+ Coverage   55.03%   55.13%   +0.10%     
==========================================
  Files         513      513              
  Lines       56959    56958       -1     
==========================================
+ Hits        31346    31404      +58     
+ Misses      22267    22198      -69     
- Partials     3346     3356      +10     
Flag Coverage Δ
unittest 55.13% <75.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zzzzhhb zzzzhhb removed the workflow/merge-hold merge-hold: code is ready but still has dependency label Mar 14, 2024
@zzzzhhb zzzzhhb merged commit ffa4262 into kubewharf:main Mar 14, 2024
13 of 15 checks passed
luomingmeng pushed a commit to luomingmeng/katalyst-core that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants