Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix vpa condition RecommendationApplied #51

Merged

Conversation

luomingmeng
Copy link
Collaborator

@luomingmeng luomingmeng commented May 5, 2023

What type of PR is this?

Bug fixes

What this PR does / why we need it:

fix vpa condition RecommendationApplied

@luomingmeng luomingmeng added bug Something isn't working workflow/draft draft: no need to review labels May 5, 2023
@luomingmeng luomingmeng added this to the v0.2 milestone May 5, 2023
@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Patch coverage: 60.52% and project coverage change: +0.02 🎉

Comparison is base (a47a4b5) 51.24% compared to head (0147b67) 51.27%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
+ Coverage   51.24%   51.27%   +0.02%     
==========================================
  Files         317      317              
  Lines       32337    32366      +29     
==========================================
+ Hits        16571    16595      +24     
- Misses      13823    13829       +6     
+ Partials     1943     1942       -1     
Flag Coverage Δ
unittest 51.27% <60.52%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/controller/vpa/util/api.go 61.86% <ø> (-2.55%) ⬇️
pkg/controller/vpa/vpa_status.go 61.46% <60.00%> (+1.67%) ⬆️
pkg/util/vpa.go 55.69% <60.00%> (+0.18%) ⬆️
pkg/controller/vpa/vparec.go 32.59% <66.66%> (+0.50%) ⬆️

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@luomingmeng luomingmeng force-pushed the dev/fix_vpa_status_condition branch from 87cfab2 to 0a59a7d Compare May 6, 2023 02:15
@luomingmeng luomingmeng marked this pull request as ready for review May 6, 2023 02:15
@luomingmeng luomingmeng added workflow/need-review review: test succeeded, need to review and removed workflow/draft draft: no need to review labels May 6, 2023
@luomingmeng luomingmeng force-pushed the dev/fix_vpa_status_condition branch from 0a59a7d to 0147b67 Compare May 6, 2023 03:39
@luomingmeng luomingmeng requested a review from csfldf May 6, 2023 03:49
@luomingmeng luomingmeng requested a review from waynepeking348 May 6, 2023 03:51
@waynepeking348 waynepeking348 merged commit cd0c370 into kubewharf:main May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working workflow/need-review review: test succeeded, need to review
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants