Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ServiceExtendedIndicator return nil object #515

Conversation

luomingmeng
Copy link
Collaborator

What type of PR is this?

Bug fixes

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 22.72727% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 55.48%. Comparing base (2d6e0a3) to head (27b95a1).
Report is 6 commits behind head on main.

Files Patch % Lines
pkg/metaserver/spd/manager.go 22.72% 13 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #515      +/-   ##
==========================================
- Coverage   55.52%   55.48%   -0.04%     
==========================================
  Files         552      552              
  Lines       59056    59188     +132     
==========================================
+ Hits        32788    32842      +54     
- Misses      22842    22918      +76     
- Partials     3426     3428       +2     
Flag Coverage Δ
unittest 55.48% <22.72%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waynepeking348 waynepeking348 marked this pull request as ready for review March 25, 2024 04:09
@waynepeking348 waynepeking348 merged commit c10d1d1 into kubewharf:main Mar 25, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants