-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sysadvisor): add healthz check #520
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzzzhhb
requested review from
sun-yuliang,
nightmeng and
luomingmeng
as code owners
March 25, 2024 13:41
zzzzhhb
added
enhancement
New feature or request
workflow/need-review
review: test succeeded, need to review
workflow/merge-hold
merge-hold: code is ready but still has dependency
labels
Mar 25, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #520 +/- ##
==========================================
- Coverage 55.67% 55.52% -0.16%
==========================================
Files 552 551 -1
Lines 59419 59507 +88
==========================================
- Hits 33083 33041 -42
- Misses 22899 23031 +132
+ Partials 3437 3435 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zzzzhhb
force-pushed
the
healthz
branch
2 times, most recently
from
March 26, 2024 09:00
abc6f7c
to
7737c2b
Compare
nightmeng
previously approved these changes
Mar 26, 2024
zzzzhhb
added
workflow/merge-ready
merge-ready: code is ready and can be merged
and removed
workflow/merge-hold
merge-hold: code is ready but still has dependency
labels
Apr 7, 2024
nightmeng
approved these changes
Apr 8, 2024
sun-yuliang
approved these changes
Apr 8, 2024
csfldf
approved these changes
Apr 8, 2024
waynepeking348
pushed a commit
that referenced
this pull request
Apr 12, 2024
luomingmeng
pushed a commit
to luomingmeng/katalyst-core
that referenced
this pull request
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
workflow/merge-ready
merge-ready: code is ready and can be merged
workflow/need-review
review: test succeeded, need to review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Enhancements
What this PR does / why we need it:
add healthz check
Which issue(s) this PR fixes:
Special notes for your reviewer: