Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sysadvisor): add healthz check #520

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Conversation

zzzzhhb
Copy link
Collaborator

@zzzzhhb zzzzhhb commented Mar 25, 2024

What type of PR is this?

Enhancements

What this PR does / why we need it:

add healthz check

Which issue(s) this PR fixes:

Special notes for your reviewer:

@zzzzhhb zzzzhhb self-assigned this Mar 25, 2024
@zzzzhhb zzzzhhb added enhancement New feature or request workflow/need-review review: test succeeded, need to review workflow/merge-hold merge-hold: code is ready but still has dependency labels Mar 25, 2024
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 54.42177% with 67 lines in your changes are missing coverage. Please review.

Project coverage is 55.52%. Comparing base (b122f7b) to head (f1f8720).

Files Patch % Lines
pkg/agent/evictionmanager/manager.go 10.34% 26 Missing ⚠️
.../agent/metric/provisioner/malachite/provisioner.go 17.24% 24 Missing ⚠️
...t/evictionmanager/plugin/memory/system_pressure.go 62.50% 6 Missing ⚠️
pkg/agent/evictionmanager/conditions.go 0.00% 5 Missing ⚠️
pkg/agent/resourcemanager/fetcher/manager.go 88.88% 1 Missing and 1 partial ⚠️
pkg/agent/sysadvisor/plugin/metacache/metacache.go 75.00% 1 Missing ⚠️
...nt/sysadvisor/plugin/qosaware/server/cpu_server.go 66.66% 1 Missing ⚠️
...sysadvisor/plugin/qosaware/server/memory_server.go 66.66% 1 Missing ⚠️
pkg/metaserver/agent/pod/pod.go 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #520      +/-   ##
==========================================
- Coverage   55.67%   55.52%   -0.16%     
==========================================
  Files         552      551       -1     
  Lines       59419    59507      +88     
==========================================
- Hits        33083    33041      -42     
- Misses      22899    23031     +132     
+ Partials     3437     3435       -2     
Flag Coverage Δ
unittest 55.52% <54.42%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zzzzhhb zzzzhhb force-pushed the healthz branch 2 times, most recently from abc6f7c to 7737c2b Compare March 26, 2024 09:00
@zzzzhhb zzzzhhb requested a review from csfldf as a code owner March 26, 2024 09:00
nightmeng
nightmeng previously approved these changes Mar 26, 2024
@zzzzhhb zzzzhhb added workflow/merge-ready merge-ready: code is ready and can be merged and removed workflow/merge-hold merge-hold: code is ready but still has dependency labels Apr 7, 2024
@zzzzhhb zzzzhhb requested a review from nightmeng April 7, 2024 06:06
@zzzzhhb zzzzhhb merged commit e717ecc into kubewharf:main Apr 8, 2024
11 of 12 checks passed
luomingmeng pushed a commit to luomingmeng/katalyst-core that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request workflow/merge-ready merge-ready: code is ready and can be merged workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants