Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(*): add metric #521

Merged
merged 1 commit into from
Mar 26, 2024
Merged

chore(*): add metric #521

merged 1 commit into from
Mar 26, 2024

Conversation

cheney-lin
Copy link
Member

What type of PR is this?

Enhancements

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Signed-off-by: linzhecheng <linzhecheng@bytedance.com>
@cheney-lin cheney-lin requested a review from luomingmeng as a code owner March 26, 2024 03:22
@cheney-lin cheney-lin added enhancement New feature or request workflow/need-review review: test succeeded, need to review labels Mar 26, 2024
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 55.36%. Comparing base (1521631) to head (71a9c10).
Report is 2 commits behind head on main.

Files Patch % Lines
pkg/agent/resourcemanager/fetcher/manager.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #521      +/-   ##
==========================================
- Coverage   55.70%   55.36%   -0.35%     
==========================================
  Files         552      552              
  Lines       59368    59381      +13     
==========================================
- Hits        33073    32876     -197     
- Misses      22854    23071     +217     
+ Partials     3441     3434       -7     
Flag Coverage Δ
unittest 55.36% <0.00%> (-0.35%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luomingmeng luomingmeng merged commit 58177dd into kubewharf:main Mar 26, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants