Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report numa sibling and memory bandwidth #533

Conversation

luomingmeng
Copy link
Collaborator

What type of PR is this?

Enhancements

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

@luomingmeng luomingmeng self-assigned this Apr 2, 2024
@luomingmeng luomingmeng force-pushed the dev/report-numa-sibling-and-memory-bandwidth branch 4 times, most recently from f2ce932 to efc6ee3 Compare April 3, 2024 13:28
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 75.46296% with 53 lines in your changes are missing coverage. Please review.

Project coverage is 55.62%. Comparing base (b122f7b) to head (8b92ba9).
Report is 6 commits behind head on main.

❗ Current head 8b92ba9 differs from pull request most recent head 02f956a. Consider uploading reports for the commit 02f956a to get more accurate results

Files Patch % Lines
...nager/fetcher/kubelet/topology/topology_adapter.go 66.19% 17 Missing and 7 partials ⚠️
pkg/metaserver/spd/manager.go 66.66% 14 Missing and 6 partials ⚠️
pkg/util/spd.go 66.66% 4 Missing ⚠️
pkg/metaserver/spd/util.go 70.00% 1 Missing and 2 partials ⚠️
pkg/metaserver/spd/fetcher.go 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #533      +/-   ##
==========================================
- Coverage   55.67%   55.62%   -0.06%     
==========================================
  Files         552      553       +1     
  Lines       59419    59621     +202     
==========================================
+ Hits        33083    33163      +80     
- Misses      22899    23024     +125     
+ Partials     3437     3434       -3     
Flag Coverage Δ
unittest 55.62% <75.46%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luomingmeng luomingmeng marked this pull request as ready for review April 7, 2024 02:24
@luomingmeng luomingmeng force-pushed the dev/report-numa-sibling-and-memory-bandwidth branch 2 times, most recently from ef877c0 to 4e3e5ff Compare April 7, 2024 03:09
@luomingmeng luomingmeng force-pushed the dev/report-numa-sibling-and-memory-bandwidth branch from 9e67c15 to 3e80581 Compare April 7, 2024 06:13
pkg/metaserver/spd/manager.go Outdated Show resolved Hide resolved
pkg/metaserver/spd/util.go Show resolved Hide resolved
@luomingmeng luomingmeng force-pushed the dev/report-numa-sibling-and-memory-bandwidth branch 5 times, most recently from 8b92ba9 to bea1d26 Compare April 7, 2024 11:00
@luomingmeng luomingmeng added the workflow/need-review review: test succeeded, need to review label Apr 7, 2024
csfldf
csfldf previously approved these changes Apr 7, 2024
@luomingmeng luomingmeng force-pushed the dev/report-numa-sibling-and-memory-bandwidth branch from bea1d26 to d7681c8 Compare April 7, 2024 17:01
@luomingmeng luomingmeng force-pushed the dev/report-numa-sibling-and-memory-bandwidth branch 3 times, most recently from b2d1202 to 3bee71a Compare April 8, 2024 08:42
@luomingmeng luomingmeng force-pushed the dev/report-numa-sibling-and-memory-bandwidth branch from 3bee71a to 6aab107 Compare April 8, 2024 12:37
@luomingmeng luomingmeng added the workflow/merge-ready merge-ready: code is ready and can be merged label Apr 8, 2024
@luomingmeng luomingmeng force-pushed the dev/report-numa-sibling-and-memory-bandwidth branch from 6aab107 to 347f982 Compare April 8, 2024 12:52
2. kubelet reporter plugin support report numa memory bandwidth allocatable/capacity and allocation
@luomingmeng luomingmeng force-pushed the dev/report-numa-sibling-and-memory-bandwidth branch 5 times, most recently from ef68213 to 779d640 Compare April 9, 2024 03:58
@luomingmeng luomingmeng force-pushed the dev/report-numa-sibling-and-memory-bandwidth branch from 779d640 to 02f956a Compare April 9, 2024 04:48
@waynepeking348 waynepeking348 merged commit c2738cd into kubewharf:main Apr 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore workflow/merge-ready merge-ready: code is ready and can be merged workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants