refactor(sysadvisor): support dynamic enable memory guard #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheney-lin
requested review from
nightmeng,
sun-yuliang and
waynepeking348
as code owners
cheney-lin
force-pushed
the
dev/mem_guard
branch
2 times, most recently
from
5e5fb3f to
18d5194
Compare
cheney-lin
changed the title
cheney-lin
force-pushed
the
dev/mem_guard
branch
from
18d5194 to
80d8827
Compare
cheney-lin
added
enhancement
cheney-lin
force-pushed
the
dev/mem_guard
branch
from
80d8827 to
83cbc8c
Compare
nightmeng
previously approved these changes
Apr 12, 2024
sun-yuliang
previously approved these changes
Apr 12, 2024
waynepeking348
dismissed stale reviews from sun-yuliang and nightmeng
via
a4c60d7
waynepeking348
previously approved these changes
Apr 15, 2024
cheney-lin
dismissed
waynepeking348’s stale review
The merge-base changed after approval.
waynepeking348
previously approved these changes
Apr 15, 2024
cheney-lin
dismissed
waynepeking348’s stale review
The merge-base changed after approval.
nightmeng
previously approved these changes
Apr 15, 2024
cheney-lin
dismissed
nightmeng’s stale review
The merge-base changed after approval.
The current memory protection mechanism is achieved by setting the memory limit of the Besteffort group to avoid memory overflows. However, when calculating the limit, the cache of high-priority services is considered as reclaimable, so that direct memory reclamation can still be triggered when memory bursting. This MR refactors the calculation logic. Firstly, we calculates the safety memory upper limit for each available NUMA node, and then sums them up to obtain the result. The upper limit for each NUMA node is calculated as followed: NUMA free memory + Besteffort group memory used on the NUMA node - reserved memory. Signed-off-by: linzhecheng <linzhecheng@bytedance.com>
Signed-off-by: linzhecheng <linzhecheng@bytedance.com>
cheney-lin
force-pushed
the
dev/mem_guard
branch
from
a4c60d7 to
1e39f1e
Compare
waynepeking348
approved these changes
Apr 15, 2024
nightmeng
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Enhancements
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer: