refine coding styles for cpu&memory plugin #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waynepeking348
added
style
workflow/need-review
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #54 +/- ##
==========================================
+ Coverage 51.30% 52.52% +1.22%
==========================================
Files 318 348 +30
Lines 32418 34266 +1848
==========================================
+ Hits 16632 17999 +1367
- Misses 13840 14137 +297
- Partials 1946 2130 +184
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
csfldf
reviewed
May 21, 2023
pkg/agent/qrm-plugins/cpu/dynamicpolicy/policy_hint_handlers.go
Outdated
Show resolved
Hide resolved
pkg/agent/qrm-plugins/memory/dynamicpolicy/policy_hint_handlers.go
Outdated
Show resolved
Hide resolved
|
To be honest, I think the risk and burden of making such a large change to these codes are far more than the benefits, especially when it's already running online. But it's been done, I've tried my best to check if modifications will cause problems , but it's really hard to identify the difference between all the changes and the original codes. |
waynepeking348
force-pushed
the
refine_qrm_cpu_memory_plugin
branch
from
5d9ec8a to
227299e
Compare
waynepeking348
force-pushed
the
refine_qrm_cpu_memory_plugin
branch
from
fafa358 to
9aa77a4
Compare
waynepeking348
force-pushed
the
refine_qrm_cpu_memory_plugin
branch
2 times, most recently
from
fe77380 to
e65f7c9
Compare
csfldf
force-pushed
the
refine_qrm_cpu_memory_plugin
branch
from
e65f7c9 to
b24b294
Compare
csfldf
added
workflow/merge-ready
csfldf
approved these changes
May 31, 2023
luomingmeng
approved these changes
May 31, 2023
luomingmeng
approved these changes
May 31, 2023
luomingmeng
approved these changes
May 31, 2023
luomingmeng
pushed a commit
to luomingmeng/katalyst-core
that referenced
this pull request
Oct 11, 2024
* refine coding styles for cpu&memory plugin * fix styles and fix bugs for cpu/memory plugin according to comments * refine(qrm): add detail comments for complex codes of qrm plugins * refine(qrm): fix conflicts in rebase numa_exclusive feature * fix(qrm): ensures dedicated_cores owner pool non-empty * fix comment typo and refine numa-execlusice judgement * remove useless functions --------- Co-authored-by: 孙健俞 <sunjianyu@bytedance.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
refactor
What this PR does / why we need it:
currently, qrm plugin is a little complicated and lack of abstraction for similar functionalities
this pr is for cpu and memory plugin