-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add TransparentMemoryOffloading plugin to trigger memory offloading #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c16fa8b
to
2da190f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #549 +/- ##
==========================================
+ Coverage 55.78% 55.94% +0.15%
==========================================
Files 524 532 +8
Lines 48534 49593 +1059
==========================================
+ Hits 27077 27744 +667
- Misses 18025 18316 +291
- Partials 3432 3533 +101
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
4b123a4
to
9d7a508
Compare
csfldf
reviewed
Apr 19, 2024
csfldf
reviewed
Apr 19, 2024
pkg/agent/sysadvisor/plugin/qosaware/resource/memory/plugin/memory_offloading.go
Outdated
Show resolved
Hide resolved
c54c6e1
to
11e81aa
Compare
fabbb99
to
5dec9e0
Compare
csfldf
previously approved these changes
Apr 23, 2024
80893d5
to
c896257
Compare
nightmeng
approved these changes
Apr 29, 2024
…ding periodically
Signed-off-by: linzhecheng <linzhecheng@bytedance.com>
Signed-off-by: linzhecheng <linzhecheng@bytedance.com>
Signed-off-by: linzhecheng <linzhecheng@bytedance.com>
nightmeng
approved these changes
Apr 29, 2024
csfldf
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Enhancements
What this PR does / why we need it:
This feature provides ability to trigger memory offload to save memory without performance downgrade, saved memory could be used for deploy more reclaimed_cores workloads to raise CPU utilization.
Which issue(s) this PR fixes:
Special notes for your reviewer: