Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(*): add license header check to ci pipeline and fix some related issues #55

Merged
merged 4 commits into from
May 9, 2023

Conversation

caohe
Copy link
Member

@caohe caohe commented May 9, 2023

What type of PR is this?

Chore

What this PR does / why we need it:

  1. add license header scripts
  2. fix incorrect license headers
  3. remove redundant config files for lint checking
  4. add license header check to CI pipeline

Which issue(s) this PR fixes:

Special notes for your reviewer:

caohe added 3 commits May 9, 2023 11:53
Signed-off-by: caohe <caohe9603@gmail.com>
Signed-off-by: caohe <caohe9603@gmail.com>
Signed-off-by: caohe <caohe9603@gmail.com>
@caohe caohe added chore workflow/need-review review: test succeeded, need to review labels May 9, 2023
@caohe caohe added this to the v0.2 milestone May 9, 2023
@caohe caohe marked this pull request as ready for review May 9, 2023 03:58
Signed-off-by: caohe <caohe9603@gmail.com>
@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.04 ⚠️

Comparison is base (6c02ac2) 51.33% compared to head (21d86d9) 51.30%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
- Coverage   51.33%   51.30%   -0.04%     
==========================================
  Files         318      318              
  Lines       32418    32418              
==========================================
- Hits        16642    16632      -10     
- Misses      13832    13840       +8     
- Partials     1944     1946       +2     
Flag Coverage Δ
unittest 51.30% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...p/options/eviction/cpu_pressure_eviction_plugin.go 45.09% <ø> (ø)
...ptions/eviction/memory_pressure_eviction_plugin.go 48.88% <ø> (ø)
...d/katalyst-agent/app/options/qrm/network_plugin.go 48.48% <ø> (ø)
...kg/agent/evictionmanager/plugin/memory_pressure.go 74.48% <ø> (ø)
.../agent/qrm-plugins/network/dynamicpolicy/policy.go 44.85% <ø> (ø)
...fig/agent/eviction/cpu_pressure_eviction_plugin.go 100.00% <ø> (ø)
.../agent/eviction/memory_pressure_eviction_plugin.go 100.00% <ø> (ø)
pkg/config/agent/qrm/network_plugin.go 100.00% <ø> (ø)
pkg/metaserver/agent/metric/fake_metric.go 64.10% <ø> (ø)
pkg/metaserver/config/config.go 67.14% <ø> (ø)
... and 8 more

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@caohe caohe added workflow/merge-ready merge-ready: code is ready and can be merged and removed workflow/need-review review: test succeeded, need to review labels May 9, 2023
@waynepeking348 waynepeking348 merged commit b37964e into kubewharf:main May 9, 2023
@caohe caohe deleted the license branch May 11, 2023 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore workflow/merge-ready merge-ready: code is ready and can be merged
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

3 participants