Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ioweight: adding pod level setting #550

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

lubinszARM
Copy link
Contributor

What type of PR is this?

Bug fixes

What this PR does / why we need it:

[bugfix] Missing pod level setting for io.weight

Which issue(s) this PR fixes:

Missing pod level setting for io.weight

Special notes for your reviewer:

None

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

Attention: Patch coverage is 55.81395% with 19 lines in your changes missing coverage. Please review.

Project coverage is 56.74%. Comparing base (d3a4e78) to head (135eee0).
Report is 18 commits behind head on main.

Files Patch % Lines
...qrm-plugins/io/handlers/ioweight/ioweight_linux.go 43.75% 9 Missing ⚠️
...ent/qrm-plugins/io/handlers/iocost/iocost_linux.go 65.21% 8 Missing ⚠️
cmd/katalyst-agent/app/options/qrm/io_plugin.go 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #550      +/-   ##
==========================================
- Coverage   56.82%   56.74%   -0.09%     
==========================================
  Files         545      545              
  Lines       51559    52018     +459     
==========================================
+ Hits        29300    29518     +218     
- Misses      18549    18779     +230     
- Partials     3710     3721      +11     
Flag Coverage Δ
unittest 56.74% <55.81%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Robin Lu <robin.lu@bytedance.com>
@csfldf csfldf requested a review from xu282934741 July 1, 2024 08:22
csfldf
csfldf previously approved these changes Jul 2, 2024
adding a strict mode to prevent a potential kernel deadlock bug

Signed-off-by: Robin Lu <robin.lu@bytedance.com>
@xu282934741 xu282934741 self-requested a review July 10, 2024 10:03
@xu282934741 xu282934741 self-requested a review July 10, 2024 10:04
@xu282934741 xu282934741 merged commit ba6c2cd into kubewharf:main Jul 10, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants