Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(qrm): use async worker to set extra cg mem limit to avoid thread stucking #563

Merged
merged 1 commit into from
May 6, 2024

Conversation

csfldf
Copy link
Collaborator

@csfldf csfldf commented Apr 29, 2024

feat(qrm): use async worker to set extra cg mem limit to avoid thread stucking

@csfldf csfldf force-pushed the dev/async_mem_limit branch 2 times, most recently from 6f0907a to effa978 Compare April 29, 2024 06:28
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 69.56522% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 56.01%. Comparing base (7a1e3f1) to head (ff01a30).
Report is 1 commits behind head on main.

Files Patch % Lines
pkg/util/cgroup/manager/cgroup.go 68.75% 8 Missing and 2 partials ⚠️
...ins/memory/dynamicpolicy/policy_advisor_handler.go 75.00% 2 Missing ⚠️
pkg/util/asyncworker/async_workers.go 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #563      +/-   ##
==========================================
+ Coverage   55.94%   56.01%   +0.07%     
==========================================
  Files         532      532              
  Lines       49593    49624      +31     
==========================================
+ Hits        27744    27797      +53     
+ Misses      18316    18279      -37     
- Partials     3533     3548      +15     
Flag Coverage Δ
unittest 56.01% <69.56%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cheney-lin
cheney-lin previously approved these changes Apr 29, 2024
@csfldf csfldf force-pushed the dev/async_mem_limit branch from b3d0110 to ff01a30 Compare April 30, 2024 04:11
@csfldf csfldf merged commit cdda888 into kubewharf:main May 6, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants