Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ut failed on macOS #58

Merged
merged 1 commit into from
May 9, 2023

Conversation

cheney-lin
Copy link
Member

What type of PR is this?

Bug fixes

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Signed-off-by: linzhecheng <linzhecheng@bytedance.com>
@cheney-lin cheney-lin requested a review from waynepeking348 May 9, 2023 15:20
@cheney-lin cheney-lin added bug Something isn't working workflow/need-review review: test succeeded, need to review labels May 9, 2023
@cheney-lin cheney-lin added workflow/merge-ready merge-ready: code is ready and can be merged and removed workflow/need-review review: test succeeded, need to review labels May 9, 2023
@cheney-lin cheney-lin requested a review from csfldf May 9, 2023 15:30
@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.07 🎉

Comparison is base (21d86d9) 51.30% compared to head (6877f84) 51.37%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
+ Coverage   51.30%   51.37%   +0.07%     
==========================================
  Files         318      318              
  Lines       32418    32419       +1     
==========================================
+ Hits        16632    16656      +24     
+ Misses      13840    13823      -17     
+ Partials     1946     1940       -6     
Flag Coverage Δ
unittest 51.37% <0.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/agent/qrm-plugins/cpu/dynamicpolicy/policy.go 38.42% <0.00%> (+0.08%) ⬆️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@waynepeking348 waynepeking348 merged commit e7f1116 into kubewharf:main May 9, 2023
@cheney-lin cheney-lin deleted the fix/ut_fail_on_mac branch May 9, 2023 15:35
luomingmeng pushed a commit to luomingmeng/katalyst-core that referenced this pull request Oct 11, 2024
Signed-off-by: linzhecheng <linzhecheng@bytedance.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working workflow/merge-ready merge-ready: code is ready and can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants