Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: convert memory by quantity.Value in overcommit controller #588

Merged

Conversation

WangZzzhe
Copy link
Collaborator

What type of PR is this?

Bug fixes

What this PR does / why we need it:

Memory value overflow when node patch a large memory allocatable in status, eg. '1Ei'.
Convert memory value by quantity.Value which can cover larger values than MilliValue.

Which issue(s) this PR fixes:

Special notes for your reviewer:

@WangZzzhe WangZzzhe added bug Something isn't working workflow/need-review review: test succeeded, need to review labels May 21, 2024
@WangZzzhe WangZzzhe requested a review from waynepeking348 May 21, 2024 08:01
@WangZzzhe WangZzzhe self-assigned this May 21, 2024
Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.16%. Comparing base (74b648c) to head (6dbc70d).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #588      +/-   ##
==========================================
+ Coverage   56.06%   56.16%   +0.10%     
==========================================
  Files         534      535       +1     
  Lines       49807    49831      +24     
==========================================
+ Hits        27924    27988      +64     
+ Misses      18325    18292      -33     
+ Partials     3558     3551       -7     
Flag Coverage Δ
unittest 56.16% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waynepeking348 waynepeking348 merged commit 480f2d7 into kubewharf:main May 27, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants