support utilization based canonical cpu headroom policy #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luomingmeng
added
enhancement
luomingmeng
force-pushed
the
dev/support_dynamic_headroom_policy
branch
2 times, most recently
from
270a6b4 to
e1b5e39
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #59 +/- ##
==========================================
+ Coverage 51.30% 51.54% +0.23%
==========================================
Files 318 325 +7
Lines 32418 32999 +581
==========================================
+ Hits 16632 17009 +377
- Misses 13840 13996 +156
- Partials 1946 1994 +48
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
luomingmeng
force-pushed
the
dev/support_dynamic_headroom_policy
branch
11 times, most recently
from
ce90d3c to
6b4dcd9
Compare
luomingmeng
added
workflow/need-review
luomingmeng
force-pushed
the
dev/support_dynamic_headroom_policy
branch
2 times, most recently
from
c3ca424 to
f17d1ac
Compare
| } | ||
|
|
||
| func (p *PolicyAdaptive) Update() error { | ||
| regionInfo, ok := p.metaReader.GetRegionInfo(p.regionName) |
There was a problem hiding this comment.
why we need to get region-info and judge with its type? should we just verify this logic when NewPolicyAdaptive is called? for dedicated_cores, can it still work since it will never update() with nil error at all?
luomingmeng
force-pushed
the
dev/support_dynamic_headroom_policy
branch
2 times, most recently
from
18616a4 to
3ae3eac
Compare
luomingmeng
force-pushed
the
dev/support_dynamic_headroom_policy
branch
from
3ae3eac to
a7ef6d8
Compare
luomingmeng
changed the title
waynepeking348
approved these changes
May 15, 2023
sun-yuliang
approved these changes
May 16, 2023
luomingmeng
added
workflow/merge-ready
luomingmeng
added a commit
to luomingmeng/katalyst-core
that referenced
this pull request
Oct 11, 2024
* support adaptive cpu headroom policy * fix network policy register not import path * rename sysadvisor RegisterHealthzCheckRules to RegisterAdvisorPlugin * change policy name adaptive to utilization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Features
What this PR does / why we need it:
To increase the utilization of reclaimed_cores pool, the cpu headroom report to cnr can be oversold to schedule more reclaimed_cores workload to the machine
Which issue(s) this PR fixes:
Special notes for your reviewer: