Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refine and fix checkLabelSelectorOverlap #599

Merged

Conversation

luomingmeng
Copy link
Collaborator

What type of PR is this?

Bug fixes

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

@luomingmeng luomingmeng added bug Something isn't working workflow/need-review review: test succeeded, need to review labels May 30, 2024
@luomingmeng luomingmeng self-assigned this May 30, 2024
@luomingmeng luomingmeng marked this pull request as ready for review May 30, 2024 06:55
Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.00%. Comparing base (5e1814b) to head (1d382df).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #599      +/-   ##
==========================================
- Coverage   56.14%   56.00%   -0.14%     
==========================================
  Files         535      535              
  Lines       49865    49869       +4     
==========================================
- Hits        27997    27930      -67     
- Misses      18307    18387      +80     
+ Partials     3561     3552       -9     
Flag Coverage Δ
unittest 56.00% <100.00%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waynepeking348 waynepeking348 merged commit ab76507 into kubewharf:main Jun 11, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working workflow/need-review review: test succeeded, need to review
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants