Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agent get SPD syncly & spd creation improvement #606

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

ddjjia
Copy link
Contributor

@ddjjia ddjjia commented Jun 3, 2024

https://github.com/kubewharf/katalyst-core/pull/558/commits
https://github.com/kubewharf/katalyst-core/pull/561/commits

What type of PR is this?

What this PR does / why we need it:

agent get SPD syncly & spd creation improvement

Which issue(s) this PR fixes:

Special notes for your reviewer:

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

Attention: Patch coverage is 54.93827% with 73 lines in your changes missing coverage. Please review.

Project coverage is 56.86%. Comparing base (65905ce) to head (8e82f8c).

Files Patch % Lines
pkg/controller/spd/spd.go 54.62% 42 Missing and 12 partials ⚠️
pkg/metaserver/spd/fetcher.go 61.29% 9 Missing and 3 partials ⚠️
pkg/controller/spd/indicator-plugin/plugin.go 0.00% 2 Missing ⚠️
...roller/spd/indicator-plugin/plugins/ihpa/plugin.go 0.00% 2 Missing ⚠️
...ugin/plugins/resource-portrait/indicator_plugin.go 0.00% 2 Missing ⚠️
...atalyst-agent/app/options/metaserver/metaserver.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #606      +/-   ##
==========================================
+ Coverage   56.74%   56.86%   +0.12%     
==========================================
  Files         552      552              
  Lines       52626    52735     +109     
==========================================
+ Hits        29860    29988     +128     
+ Misses      19014    18982      -32     
- Partials     3752     3765      +13     
Flag Coverage Δ
unittest 56.86% <54.93%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ddjjia ddjjia force-pushed the feat/mem-bandwidth-all-changes branch 4 times, most recently from ace91a1 to 1842b0d Compare June 18, 2024 20:01
@ddjjia ddjjia force-pushed the feat/mem-bandwidth-all-changes branch 4 times, most recently from 041e068 to 7a859c2 Compare June 28, 2024 21:03
@ddjjia ddjjia requested a review from xu282934741 as a code owner July 3, 2024 05:24
@ddjjia ddjjia force-pushed the feat/mem-bandwidth-all-changes branch 2 times, most recently from 956dc3b to 1b1a289 Compare July 3, 2024 19:23
luomingmeng
luomingmeng previously approved these changes Jul 4, 2024
@luomingmeng luomingmeng added enhancement New feature or request workflow/need-review review: test succeeded, need to review labels Jul 9, 2024
@ddjjia ddjjia force-pushed the feat/mem-bandwidth-all-changes branch from 1e1d3cd to b21825a Compare July 12, 2024 01:25
@ddjjia ddjjia force-pushed the feat/mem-bandwidth-all-changes branch from b21825a to 8e82f8c Compare July 12, 2024 06:34
@luomingmeng luomingmeng merged commit a449bc9 into kubewharf:main Jul 12, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request workflow/need-review review: test succeeded, need to review
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants