Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refine GetSiblingNumaInfo #612

Merged

Conversation

luomingmeng
Copy link
Collaborator

What type of PR is this?

Enhancements

What this PR does / why we need it:

Refine GetSiblingNumaInfo logic support sibling numa distance larger than the distance to itself

Which issue(s) this PR fixes:

Special notes for your reviewer:

@luomingmeng luomingmeng marked this pull request as ready for review June 5, 2024 11:41
@luomingmeng luomingmeng force-pushed the dev/refine-get-sibling-numa-info branch 4 times, most recently from 9b6b08c to f82cc69 Compare June 5, 2024 11:48
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 56.14%. Comparing base (abfa348) to head (f40b9c5).
Report is 1 commits behind head on main.

Files Patch % Lines
cmd/katalyst-agent/app/options/global/base.go 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #612      +/-   ##
==========================================
- Coverage   56.23%   56.14%   -0.10%     
==========================================
  Files         535      535              
  Lines       49869    49878       +9     
==========================================
- Hits        28044    28003      -41     
- Misses      18252    18318      +66     
+ Partials     3573     3557      -16     
Flag Coverage Δ
unittest 56.14% <77.77%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luomingmeng luomingmeng self-assigned this Jun 5, 2024
@luomingmeng luomingmeng added enhancement New feature or request workflow/need-review review: test succeeded, need to review labels Jun 5, 2024
@luomingmeng luomingmeng force-pushed the dev/refine-get-sibling-numa-info branch from f82cc69 to f40b9c5 Compare June 6, 2024 01:14
@waynepeking348 waynepeking348 merged commit eb4d284 into kubewharf:main Jun 11, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request workflow/need-review review: test succeeded, need to review
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants