Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(agent): refactor eviction/reporter healthz rule #614

Merged
merged 1 commit into from
Jun 8, 2024

Conversation

zzzzhhb
Copy link
Collaborator

@zzzzhhb zzzzhhb commented Jun 7, 2024

What type of PR is this?

enhancements

What this PR does / why we need it:

refactor healthz rules for eviction manager and reporter manager

Which issue(s) this PR fixes:

Special notes for your reviewer:

@zzzzhhb zzzzhhb added the workflow/need-review review: test succeeded, need to review label Jun 7, 2024
@zzzzhhb zzzzhhb self-assigned this Jun 7, 2024
@zzzzhhb zzzzhhb requested a review from luomingmeng as a code owner June 7, 2024 08:31
@zzzzhhb zzzzhhb force-pushed the refactor_eviction_healthz branch from c3d1a2c to 58675bb Compare June 7, 2024 08:47
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 73.68421% with 5 lines in your changes missing coverage. Please review.

Project coverage is 56.31%. Comparing base (11f15e8) to head (58675bb).

Files Patch % Lines
pkg/agent/evictionmanager/manager.go 0.00% 2 Missing ⚠️
...ent/evictionmanager/plugin/memory/numa_pressure.go 90.00% 1 Missing ⚠️
...t/evictionmanager/plugin/memory/system_pressure.go 50.00% 1 Missing ⚠️
...agent/evictionmanager/plugin/resource/resources.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #614      +/-   ##
==========================================
+ Coverage   56.21%   56.31%   +0.10%     
==========================================
  Files         543      543              
  Lines       50302    50314      +12     
==========================================
+ Hits        28275    28336      +61     
+ Misses      18436    18383      -53     
- Partials     3591     3595       +4     
Flag Coverage Δ
unittest 56.31% <73.68%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waynepeking348 waynepeking348 merged commit 07550c5 into kubewharf:main Jun 8, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants