fix(sysadvisor): clean up the contianers not existed in checkpoint #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the `AddContainer` request may time out due to `storeState`, causing container leaks in metaCache, so it is necessary clean up any excess containers. Signed-off-by: linzhecheng <linzhecheng@bytedance.com>
cheney-lin
added
bug
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #62 +/- ##
==========================================
- Coverage 51.30% 51.23% -0.08%
==========================================
Files 318 318
Lines 32418 32516 +98
==========================================
+ Hits 16632 16659 +27
- Misses 13840 13899 +59
- Partials 1946 1958 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
sun-yuliang
reviewed
May 12, 2023
sun-yuliang
approved these changes
May 12, 2023
waynepeking348
approved these changes
May 15, 2023
cheney-lin
added
workflow/merge-ready
luomingmeng
pushed a commit
to luomingmeng/katalyst-core
that referenced
this pull request
Oct 11, 2024
…ubewharf#62) the `AddContainer` request may time out due to `storeState`, causing container leaks in metaCache, so it is necessary clean up any excess containers. Signed-off-by: linzhecheng <linzhecheng@bytedance.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the
AddContainerrequest may time out due tostoreState, causing container leaks in metaCache, so it is necessary clean up any excess containers.What type of PR is this?
Bug fixes
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer: