-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support shared_cores overlap reclaimed_cores #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheney-lin
requested review from
csfldf,
luomingmeng,
nightmeng and
waynepeking348
as code owners
June 13, 2024 11:10
cheney-lin
added
enhancement
New feature or request
workflow/need-review
review: test succeeded, need to review
labels
Jun 13, 2024
nightmeng
reviewed
Jun 17, 2024
...gent/sysadvisor/plugin/qosaware/resource/cpu/assembler/headroomassembler/assembler_common.go
Outdated
Show resolved
Hide resolved
nightmeng
reviewed
Jun 17, 2024
...gent/sysadvisor/plugin/qosaware/resource/cpu/assembler/headroomassembler/assembler_common.go
Show resolved
Hide resolved
cheney-lin
force-pushed
the
dev/sor
branch
2 times, most recently
from
June 18, 2024 10:11
ab509d4
to
a5d8e01
Compare
nightmeng
previously approved these changes
Jun 27, 2024
...ent/sysadvisor/plugin/qosaware/resource/cpu/assembler/provisionassembler/assembler_common.go
Outdated
Show resolved
Hide resolved
cheney-lin
force-pushed
the
dev/sor
branch
5 times, most recently
from
June 28, 2024 05:16
e0766d7
to
1e2c04f
Compare
luomingmeng
reviewed
Jul 1, 2024
pkg/agent/sysadvisor/plugin/inference/modelresultfetcher/borwein/borwein.go
Outdated
Show resolved
Hide resolved
luomingmeng
reviewed
Jul 1, 2024
pkg/agent/sysadvisor/plugin/qosaware/resource/cpu/region/provisionpolicy/policy_rama.go
Outdated
Show resolved
Hide resolved
nightmeng
previously approved these changes
Jul 1, 2024
cheney-lin
force-pushed
the
dev/sor
branch
5 times, most recently
from
July 1, 2024 07:50
257abba
to
6a93859
Compare
cheney-lin
force-pushed
the
dev/sor
branch
10 times, most recently
from
July 2, 2024 05:11
36c2018
to
765de06
Compare
nightmeng
previously approved these changes
Jul 2, 2024
luomingmeng
previously approved these changes
Jul 2, 2024
pkg/agent/sysadvisor/plugin/qosaware/resource/cpu/assembler/provisionassembler/helper.go
Show resolved
Hide resolved
csfldf
previously approved these changes
Jul 2, 2024
1. add a switch to allow shared_cores overlap reclaimed_cores, if the switch is off, the calculation of headroom and provision remains semantically unchanged. 2. removed HeadroomAssemblerDedicated and preserve original assembler name for compatibility. 3. shrink headroom when region in status of upper bound. 4. support dynamic config for cpu provision Signed-off-by: linzhecheng <linzhecheng@bytedance.com>
cheney-lin
dismissed stale reviews from csfldf, luomingmeng, and nightmeng
via
July 2, 2024 10:51
9e97c26
luomingmeng
approved these changes
Jul 2, 2024
nightmeng
approved these changes
Jul 2, 2024
csfldf
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Features
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer: