Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support shared_cores overlap reclaimed_cores #625

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

cheney-lin
Copy link
Member

What type of PR is this?

Features

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

@cheney-lin cheney-lin self-assigned this Jun 13, 2024
@cheney-lin cheney-lin added enhancement New feature or request workflow/need-review review: test succeeded, need to review labels Jun 13, 2024
@cheney-lin cheney-lin force-pushed the dev/sor branch 2 times, most recently from ab509d4 to a5d8e01 Compare June 18, 2024 10:11
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 82.26164% with 80 lines in your changes missing coverage. Please review.

Project coverage is 56.83%. Comparing base (d3a4e78) to head (9e97c26).

Files Patch % Lines
.../options/dynamic/adminqos/advisor/cpu_provision.go 52.52% 37 Missing and 10 partials ⚠️
...pu/assembler/headroomassembler/assembler_common.go 83.92% 5 Missing and 4 partials ⚠️
...u/assembler/provisionassembler/assembler_common.go 94.25% 3 Missing and 2 partials ⚠️
...plugin/qosaware/resource/cpu/region/region_base.go 79.16% 2 Missing and 3 partials ⚠️
...lugin/qosaware/resource/cpu/region/region_share.go 82.60% 2 Missing and 2 partials ⚠️
...esource/cpu/assembler/provisionassembler/helper.go 92.00% 1 Missing and 1 partial ⚠️
pkg/agent/sysadvisor/types/helper.go 85.71% 1 Missing and 1 partial ⚠️
pkg/util/general/deepcopy.go 71.42% 1 Missing and 1 partial ⚠️
...p/options/dynamic/adminqos/advisor/advisor_base.go 75.00% 1 Missing ⚠️
...sysadvisor/plugin/qosaware/resource/cpu/advisor.go 90.90% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #625      +/-   ##
==========================================
+ Coverage   56.82%   56.83%   +0.01%     
==========================================
  Files         545      544       -1     
  Lines       51559    51682     +123     
==========================================
+ Hits        29300    29376      +76     
- Misses      18549    18588      +39     
- Partials     3710     3718       +8     
Flag Coverage Δ
unittest 56.83% <82.26%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

nightmeng
nightmeng previously approved these changes Jul 1, 2024
@cheney-lin cheney-lin force-pushed the dev/sor branch 10 times, most recently from 36c2018 to 765de06 Compare July 2, 2024 05:11
nightmeng
nightmeng previously approved these changes Jul 2, 2024
csfldf
csfldf previously approved these changes Jul 2, 2024
1. add a switch to allow shared_cores overlap reclaimed_cores, if the switch is off,
   the calculation of headroom and provision remains semantically unchanged.
2. removed HeadroomAssemblerDedicated and preserve original assembler name for compatibility.
3. shrink headroom when region in status of upper bound.
4.  support dynamic config for cpu provision

Signed-off-by: linzhecheng <linzhecheng@bytedance.com>
@luomingmeng luomingmeng merged commit 7e559fd into kubewharf:main Jul 2, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants