Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sysadvisor): optimize run servers #632

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

nightmeng
Copy link
Collaborator

What type of PR is this?

Enhancements

What this PR does / why we need it:

Optimize the advisor run servers logic

Which issue(s) this PR fixes:

Special notes for your reviewer:

@nightmeng nightmeng force-pushed the dev/fix-start-server branch 8 times, most recently from 460c3e8 to 8ae9358 Compare June 21, 2024 06:42
@nightmeng nightmeng force-pushed the dev/fix-start-server branch 4 times, most recently from 68daf76 to f9e7640 Compare June 25, 2024 09:22
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 63.33333% with 11 lines in your changes missing coverage. Please review.

Project coverage is 56.60%. Comparing base (3d88b72) to head (3ed017f).
Report is 4 commits behind head on main.

Files Patch % Lines
...t/sysadvisor/plugin/qosaware/server/base_server.go 52.38% 6 Missing and 4 partials ⚠️
...sysadvisor/plugin/qosaware/resource/cpu/advisor.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #632      +/-   ##
==========================================
- Coverage   56.82%   56.60%   -0.23%     
==========================================
  Files         545      545              
  Lines       51561    51555       -6     
==========================================
- Hits        29300    29182     -118     
- Misses      18551    18680     +129     
+ Partials     3710     3693      -17     
Flag Coverage Δ
unittest 56.60% <63.33%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nightmeng nightmeng requested review from csfldf and removed request for waynepeking348 June 25, 2024 09:34
@nightmeng nightmeng force-pushed the dev/fix-start-server branch from f9e7640 to 22f4911 Compare June 26, 2024 11:19
luomingmeng
luomingmeng previously approved these changes Jun 26, 2024
@nightmeng nightmeng merged commit 022f72a into kubewharf:main Jun 27, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants