-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add npd controller #633
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WangZzzhe
added
enhancement
New feature or request
workflow/need-review
review: test succeeded, need to review
labels
Jun 21, 2024
WangZzzhe
requested review from
csfldf,
luomingmeng,
caohe and
waynepeking348
as code owners
June 21, 2024 03:35
WangZzzhe
force-pushed
the
dev/npd-controller
branch
from
June 21, 2024 03:37
f452e74
to
1829152
Compare
WangZzzhe
added
workflow/draft
draft: no need to review
and removed
workflow/need-review
review: test succeeded, need to review
labels
Jun 21, 2024
WangZzzhe
force-pushed
the
dev/npd-controller
branch
from
June 21, 2024 04:05
1829152
to
810e743
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #633 +/- ##
==========================================
- Coverage 57.18% 57.08% -0.11%
==========================================
Files 558 566 +8
Lines 54146 54492 +346
==========================================
+ Hits 30966 31109 +143
- Misses 19305 19489 +184
- Partials 3875 3894 +19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
WangZzzhe
added
workflow/need-review
review: test succeeded, need to review
and removed
workflow/draft
draft: no need to review
labels
Jul 1, 2024
WangZzzhe
force-pushed
the
dev/npd-controller
branch
from
July 12, 2024 06:41
810e743
to
23654f3
Compare
WangZzzhe
force-pushed
the
dev/npd-controller
branch
4 times, most recently
from
July 12, 2024 09:41
0076ce5
to
e525304
Compare
WangZzzhe
force-pushed
the
dev/npd-controller
branch
from
August 28, 2024 08:13
b3ee8a7
to
7cd341f
Compare
luomingmeng
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Features
What this PR does / why we need it:
add NPD controller
api should be replaced after kubewharf/katalyst-api#84 merged