Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add npd controller #633

Merged
merged 3 commits into from
Aug 28, 2024
Merged

Conversation

WangZzzhe
Copy link
Collaborator

What type of PR is this?

Features

What this PR does / why we need it:

add NPD controller
api should be replaced after kubewharf/katalyst-api#84 merged

@WangZzzhe WangZzzhe added enhancement New feature or request workflow/need-review review: test succeeded, need to review labels Jun 21, 2024
@WangZzzhe WangZzzhe requested a review from zzzzhhb June 21, 2024 03:35
@WangZzzhe WangZzzhe self-assigned this Jun 21, 2024
@WangZzzhe WangZzzhe force-pushed the dev/npd-controller branch from f452e74 to 1829152 Compare June 21, 2024 03:37
@WangZzzhe WangZzzhe added workflow/draft draft: no need to review and removed workflow/need-review review: test succeeded, need to review labels Jun 21, 2024
@WangZzzhe WangZzzhe changed the title Dev/npd controller feat: add npd controller Jun 21, 2024
@WangZzzhe WangZzzhe force-pushed the dev/npd-controller branch from 1829152 to 810e743 Compare June 21, 2024 04:05
Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 63.87283% with 125 lines in your changes missing coverage. Please review.

Project coverage is 57.08%. Comparing base (99996fc) to head (7cd341f).
Report is 5 commits behind head on main.

Files Patch % Lines
pkg/controller/npd/npd.go 66.16% 35 Missing and 10 partials ⚠️
pkg/controller/npd/npd_metric.go 57.81% 20 Missing and 7 partials ⚠️
pkg/controller/npd/handler.go 32.25% 16 Missing and 5 partials ⚠️
cmd/katalyst-controller/app/options/npd.go 43.47% 13 Missing ⚠️
pkg/client/control/npd.go 47.36% 8 Missing and 2 partials ⚠️
pkg/util/npd.go 80.00% 2 Missing and 2 partials ⚠️
pkg/controller/npd/metrics-plugin/manager.go 92.10% 2 Missing and 1 partial ⚠️
cmd/katalyst-controller/app/options/controller.go 66.66% 1 Missing ⚠️
pkg/controller/npd/metrics-plugin/plugin.go 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #633      +/-   ##
==========================================
- Coverage   57.18%   57.08%   -0.11%     
==========================================
  Files         558      566       +8     
  Lines       54146    54492     +346     
==========================================
+ Hits        30966    31109     +143     
- Misses      19305    19489     +184     
- Partials     3875     3894      +19     
Flag Coverage Δ
unittest 57.08% <63.87%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WangZzzhe WangZzzhe added workflow/need-review review: test succeeded, need to review and removed workflow/draft draft: no need to review labels Jul 1, 2024
@WangZzzhe WangZzzhe force-pushed the dev/npd-controller branch from 810e743 to 23654f3 Compare July 12, 2024 06:41
@WangZzzhe WangZzzhe requested a review from xu282934741 as a code owner July 12, 2024 06:41
@WangZzzhe WangZzzhe force-pushed the dev/npd-controller branch 4 times, most recently from 0076ce5 to e525304 Compare July 12, 2024 09:41
@xu282934741 xu282934741 merged commit 8f6cbb5 into kubewharf:main Aug 28, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants