Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix spd cache clear when checkpoint deleted #634

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

luomingmeng
Copy link
Collaborator

What type of PR is this?

Bug fixes

What this PR does / why we need it:

fix spd cache clear when checkpoint deleted

Which issue(s) this PR fixes:

Special notes for your reviewer:

@luomingmeng luomingmeng marked this pull request as ready for review June 21, 2024 08:08
@luomingmeng luomingmeng self-assigned this Jun 21, 2024
@luomingmeng luomingmeng added the bug Something isn't working label Jun 21, 2024
@luomingmeng luomingmeng force-pushed the dev/fix-spd-cache-clear branch from 53fe2d3 to 393f4d0 Compare June 21, 2024 08:09
@luomingmeng luomingmeng force-pushed the dev/fix-spd-cache-clear branch from 393f4d0 to 0f4d219 Compare June 21, 2024 08:17
Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 56.68%. Comparing base (4858a44) to head (393f4d0).
Report is 3 commits behind head on main.

Current head 393f4d0 differs from pull request most recent head 0f4d219

Please upload reports for the commit 0f4d219 to get more accurate results.

Files Patch % Lines
pkg/metaserver/spd/cache.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #634      +/-   ##
==========================================
- Coverage   56.75%   56.68%   -0.07%     
==========================================
  Files         545      545              
  Lines       51537    51538       +1     
==========================================
- Hits        29248    29213      -35     
- Misses      18583    18632      +49     
+ Partials     3706     3693      -13     
Flag Coverage Δ
unittest 56.68% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luomingmeng luomingmeng added the workflow/need-review review: test succeeded, need to review label Jun 26, 2024
@luomingmeng luomingmeng merged commit d8ecbb3 into kubewharf:main Jun 26, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants