Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1. perf(qrm): improve performance of calculating hints 2. feat(qrm): involve memory bandwidth when admitting in cpu plugin #650

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

csfldf
Copy link
Collaborator

@csfldf csfldf commented Jul 15, 2024

  1. perf(qrm): improve performance of calculating hints
  2. feat(qrm): involve memory bandwidth when admitting in cpu plugin

Copy link

codecov bot commented Jul 15, 2024

Codecov Report

Attention: Patch coverage is 58.57143% with 145 lines in your changes missing coverage. Please review.

Project coverage is 56.90%. Comparing base (1bf6415) to head (6196bbf).
Report is 18 commits behind head on main.

Files Patch % Lines
...-plugins/cpu/dynamicpolicy/policy_hint_handlers.go 62.06% 39 Missing and 27 partials ⚠️
pkg/util/machine/bitmask.go 38.63% 50 Missing and 4 partials ⚠️
...ugins/memory/dynamicpolicy/policy_hint_handlers.go 47.82% 7 Missing and 5 partials ⚠️
pkg/util/general/common.go 37.50% 3 Missing and 2 partials ⚠️
cmd/katalyst-agent/app/options/qrm/qrm_base.go 63.63% 4 Missing ⚠️
pkg/agent/qrm-plugins/cpu/dynamicpolicy/policy.go 50.00% 2 Missing ⚠️
pkg/util/machine/topology.go 89.47% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main     #650    +/-   ##
========================================
  Coverage   56.89%   56.90%            
========================================
  Files         552      553     +1     
  Lines       52737    53123   +386     
========================================
+ Hits        30006    30227   +221     
- Misses      18975    19097   +122     
- Partials     3756     3799    +43     
Flag Coverage Δ
unittest 56.90% <58.57%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@csfldf csfldf force-pushed the dev/mem_bw_admit branch 11 times, most recently from 08a3db3 to 99780e1 Compare July 22, 2024 03:32
@csfldf csfldf force-pushed the dev/mem_bw_admit branch from 99780e1 to aa93e27 Compare July 23, 2024 03:31
@csfldf csfldf force-pushed the dev/mem_bw_admit branch from aa93e27 to 6196bbf Compare July 23, 2024 06:28
@xu282934741 xu282934741 merged commit ee1cc39 into kubewharf:main Jul 24, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants