Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spd fetcher add config for enable service profile namespaces #651

Merged

Conversation

luomingmeng
Copy link
Collaborator

What type of PR is this?

Enhancements

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

@luomingmeng luomingmeng marked this pull request as ready for review July 16, 2024 07:59
@luomingmeng luomingmeng force-pushed the dev/spd-add-enable-namespaces-config branch from b6cbc9a to 4e05aa9 Compare July 16, 2024 08:02
@luomingmeng luomingmeng force-pushed the dev/spd-add-enable-namespaces-config branch from 4e05aa9 to acb9724 Compare July 16, 2024 08:05
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 73.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 56.88%. Comparing base (c6f9ea9) to head (acb9724).

Files Patch % Lines
...atalyst-agent/app/options/metaserver/metaserver.go 50.00% 2 Missing ⚠️
pkg/metaserver/spd/fetcher.go 81.81% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #651      +/-   ##
==========================================
- Coverage   56.89%   56.88%   -0.01%     
==========================================
  Files         552      552              
  Lines       52830    52838       +8     
==========================================
+ Hits        30057    30059       +2     
+ Misses      19013    19012       -1     
- Partials     3760     3767       +7     
Flag Coverage Δ
unittest 56.88% <73.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luomingmeng luomingmeng self-assigned this Jul 16, 2024
@luomingmeng luomingmeng added the workflow/need-review review: test succeeded, need to review label Jul 16, 2024
@luomingmeng luomingmeng merged commit 29d4745 into kubewharf:main Jul 16, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants