Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(qrm): remove dropcache when migrate numa memory #655

Merged

Conversation

yadzhang
Copy link
Collaborator

@yadzhang yadzhang commented Jul 19, 2024

What type of PR is this?

Enhancements

What this PR does / why we need it:

remove dropcache directly and use move_page to migrate cache

Which issue(s) this PR fixes:

dropcache operation can cause jitter in some sensitive small containers.

Special notes for your reviewer:

@yadzhang yadzhang requested a review from csfldf as a code owner July 19, 2024 09:34
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.90%. Comparing base (1bf6415) to head (d7ff93b).
Report is 23 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #655      +/-   ##
==========================================
+ Coverage   56.89%   56.90%   +0.01%     
==========================================
  Files         552      552              
  Lines       52737    52826      +89     
==========================================
+ Hits        30006    30063      +57     
- Misses      18975    19001      +26     
- Partials     3756     3762       +6     
Flag Coverage Δ
unittest 56.90% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cheney-lin cheney-lin added enhancement New feature or request workflow/need-review review: test succeeded, need to review labels Jul 26, 2024
@xu282934741 xu282934741 merged commit d5ebb56 into kubewharf:main Jul 26, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants