Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support to update reservedForReclaim dynamicly #659

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

cheney-lin
Copy link
Member

What type of PR is this?

Enhancements

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

@cheney-lin cheney-lin requested a review from nightmeng as a code owner July 25, 2024 23:38
@cheney-lin cheney-lin self-assigned this Jul 26, 2024
@cheney-lin cheney-lin added enhancement New feature or request workflow/need-review review: test succeeded, need to review labels Jul 26, 2024
@cheney-lin cheney-lin force-pushed the dev/dynamic_reserved branch from 1d83934 to 55d8372 Compare August 13, 2024 01:28
Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 8 lines in your changes missing coverage. Please review.

Project coverage is 56.91%. Comparing base (8ea7721) to head (d23374d).
Report is 18 commits behind head on main.

Files Patch % Lines
...ynamicpolicy/cpueviction/strategy/pressure_load.go 0.00% 1 Missing and 1 partial ⚠️
...sysadvisor/plugin/qosaware/resource/cpu/advisor.go 0.00% 1 Missing and 1 partial ⚠️
...sor/plugin/qosaware/resource/cpu/advisor_helper.go 50.00% 1 Missing and 1 partial ⚠️
pkg/util/machine/cpu.go 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #659      +/-   ##
==========================================
+ Coverage   56.79%   56.91%   +0.11%     
==========================================
  Files         556      556              
  Lines       53257    53348      +91     
==========================================
+ Hits        30248    30362     +114     
+ Misses      19200    19174      -26     
- Partials     3809     3812       +3     
Flag Coverage Δ
unittest 56.91% <33.33%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

luomingmeng
luomingmeng previously approved these changes Aug 13, 2024
nightmeng
nightmeng previously approved these changes Aug 16, 2024
Signed-off-by: linzhecheng <linzhecheng@bytedance.com>
@nightmeng nightmeng merged commit bf630ba into kubewharf:main Aug 20, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants