-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support to update reservedForReclaim dynamicly #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheney-lin
added
enhancement
New feature or request
workflow/need-review
review: test succeeded, need to review
labels
Jul 26, 2024
cheney-lin
force-pushed
the
dev/dynamic_reserved
branch
from
August 13, 2024 01:28
1d83934
to
55d8372
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #659 +/- ##
==========================================
+ Coverage 56.79% 56.91% +0.11%
==========================================
Files 556 556
Lines 53257 53348 +91
==========================================
+ Hits 30248 30362 +114
+ Misses 19200 19174 -26
- Partials 3809 3812 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
luomingmeng
previously approved these changes
Aug 13, 2024
cheney-lin
force-pushed
the
dev/dynamic_reserved
branch
from
August 15, 2024 01:28
55d8372
to
e9e0642
Compare
cheney-lin
force-pushed
the
dev/dynamic_reserved
branch
from
August 16, 2024 06:08
e9e0642
to
cf87c77
Compare
nightmeng
previously approved these changes
Aug 16, 2024
xu282934741
reviewed
Aug 19, 2024
Signed-off-by: linzhecheng <linzhecheng@bytedance.com>
cheney-lin
force-pushed
the
dev/dynamic_reserved
branch
from
August 20, 2024 07:27
cf87c77
to
d23374d
Compare
xu282934741
approved these changes
Aug 20, 2024
nightmeng
approved these changes
Aug 20, 2024
luomingmeng
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Enhancements
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer: