Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(qrm): support pod inplace update resize admit #665

Merged
merged 3 commits into from
Aug 21, 2024

Conversation

nightmeng
Copy link
Collaborator

@nightmeng nightmeng commented Aug 1, 2024

What type of PR is this?

Features

What this PR does / why we need it:

Support pod inplace update resize admit.

Which issue(s) this PR fixes:

Special notes for your reviewer:

@nightmeng nightmeng changed the title feat(qrm): support vpa topology hints feat(qrm): support vpa admit Aug 1, 2024
@nightmeng nightmeng force-pushed the dev/support-qrm-vpa-admit branch from a4a9fc5 to c1894df Compare August 1, 2024 09:55
@nightmeng nightmeng requested a review from luomingmeng August 1, 2024 09:57
@nightmeng nightmeng force-pushed the dev/support-qrm-vpa-admit branch from c1894df to 42ab645 Compare August 1, 2024 11:42
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 52.13068% with 337 lines in your changes missing coverage. Please review.

Project coverage is 57.20%. Comparing base (7d9189e) to head (4908830).
Report is 25 commits behind head on main.

Files Patch % Lines
...ns/cpu/dynamicpolicy/policy_allocation_handlers.go 32.12% 100 Missing and 12 partials ⚠️
...g/agent/qrm-plugins/memory/dynamicpolicy/policy.go 63.93% 37 Missing and 7 partials ⚠️
pkg/agent/qrm-plugins/cpu/dynamicpolicy/policy.go 61.68% 36 Missing and 5 partials ⚠️
...memory/dynamicpolicy/policy_allocation_handlers.go 43.83% 33 Missing and 8 partials ⚠️
...ugins/memory/dynamicpolicy/policy_hint_handlers.go 56.32% 29 Missing and 9 partials ⚠️
.../agent/qrm-plugins/cpu/dynamicpolicy/state/util.go 18.42% 29 Missing and 2 partials ⚠️
...-plugins/cpu/dynamicpolicy/policy_hint_handlers.go 63.07% 16 Missing and 8 partials ⚠️
pkg/agent/qrm-plugins/util/util.go 71.42% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #665      +/-   ##
==========================================
+ Coverage   56.90%   57.20%   +0.29%     
==========================================
  Files         554      556       +2     
  Lines       53185    53890     +705     
==========================================
+ Hits        30265    30827     +562     
- Misses      19123    19222      +99     
- Partials     3797     3841      +44     
Flag Coverage Δ
unittest 57.20% <52.13%> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nightmeng nightmeng force-pushed the dev/support-qrm-vpa-admit branch 13 times, most recently from ab8e010 to 8170fbe Compare August 13, 2024 09:40
@nightmeng nightmeng force-pushed the dev/support-qrm-vpa-admit branch 3 times, most recently from e8abf86 to 4587b06 Compare August 16, 2024 04:09
@luomingmeng luomingmeng requested a review from csfldf August 19, 2024 06:07
@nightmeng nightmeng force-pushed the dev/support-qrm-vpa-admit branch from 4587b06 to f3cc3cb Compare August 19, 2024 09:26
@nightmeng nightmeng force-pushed the dev/support-qrm-vpa-admit branch 4 times, most recently from 22eca8e to fd505f6 Compare August 20, 2024 06:19
csfldf
csfldf previously approved these changes Aug 20, 2024
@nightmeng nightmeng force-pushed the dev/support-qrm-vpa-admit branch from fd505f6 to 119d784 Compare August 20, 2024 06:28
@nightmeng nightmeng changed the title feat(qrm): support vpa admit feat(qrm): support pod inplace update resize admit Aug 20, 2024
@nightmeng nightmeng merged commit c2f518f into kubewharf:main Aug 21, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants