-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(qrm): support pod inplace update resize admit #665
Merged
nightmeng
merged 3 commits into
kubewharf:main
from
nightmeng:dev/support-qrm-vpa-admit
Aug 21, 2024
Merged
feat(qrm): support pod inplace update resize admit #665
nightmeng
merged 3 commits into
kubewharf:main
from
nightmeng:dev/support-qrm-vpa-admit
Aug 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nightmeng
requested review from
csfldf,
xu282934741 and
waynepeking348
as code owners
August 1, 2024 09:54
nightmeng
changed the title
feat(qrm): support vpa topology hints
feat(qrm): support vpa admit
Aug 1, 2024
nightmeng
force-pushed
the
dev/support-qrm-vpa-admit
branch
from
August 1, 2024 09:55
a4a9fc5
to
c1894df
Compare
nightmeng
force-pushed
the
dev/support-qrm-vpa-admit
branch
from
August 1, 2024 11:42
c1894df
to
42ab645
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #665 +/- ##
==========================================
+ Coverage 56.90% 57.20% +0.29%
==========================================
Files 554 556 +2
Lines 53185 53890 +705
==========================================
+ Hits 30265 30827 +562
- Misses 19123 19222 +99
- Partials 3797 3841 +44
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
nightmeng
force-pushed
the
dev/support-qrm-vpa-admit
branch
13 times, most recently
from
August 13, 2024 09:40
ab8e010
to
8170fbe
Compare
nightmeng
force-pushed
the
dev/support-qrm-vpa-admit
branch
3 times, most recently
from
August 16, 2024 04:09
e8abf86
to
4587b06
Compare
csfldf
reviewed
Aug 19, 2024
csfldf
reviewed
Aug 19, 2024
pkg/agent/qrm-plugins/memory/dynamicpolicy/policy_hint_handlers.go
Outdated
Show resolved
Hide resolved
csfldf
reviewed
Aug 19, 2024
pkg/agent/qrm-plugins/cpu/dynamicpolicy/policy_hint_handlers.go
Outdated
Show resolved
Hide resolved
csfldf
reviewed
Aug 19, 2024
pkg/agent/qrm-plugins/cpu/dynamicpolicy/policy_hint_handlers.go
Outdated
Show resolved
Hide resolved
csfldf
reviewed
Aug 19, 2024
csfldf
reviewed
Aug 19, 2024
csfldf
reviewed
Aug 19, 2024
pkg/agent/qrm-plugins/cpu/dynamicpolicy/policy_hint_handlers.go
Outdated
Show resolved
Hide resolved
csfldf
reviewed
Aug 19, 2024
csfldf
reviewed
Aug 19, 2024
pkg/agent/qrm-plugins/cpu/dynamicpolicy/policy_hint_handlers.go
Outdated
Show resolved
Hide resolved
csfldf
reviewed
Aug 19, 2024
csfldf
reviewed
Aug 19, 2024
pkg/agent/qrm-plugins/cpu/dynamicpolicy/policy_hint_handlers.go
Outdated
Show resolved
Hide resolved
csfldf
reviewed
Aug 19, 2024
pkg/agent/qrm-plugins/cpu/dynamicpolicy/policy_hint_handlers.go
Outdated
Show resolved
Hide resolved
csfldf
reviewed
Aug 19, 2024
csfldf
reviewed
Aug 19, 2024
pkg/agent/qrm-plugins/cpu/dynamicpolicy/policy_allocation_handlers.go
Outdated
Show resolved
Hide resolved
nightmeng
force-pushed
the
dev/support-qrm-vpa-admit
branch
from
August 19, 2024 09:26
4587b06
to
f3cc3cb
Compare
csfldf
reviewed
Aug 20, 2024
csfldf
reviewed
Aug 20, 2024
csfldf
reviewed
Aug 20, 2024
pkg/agent/qrm-plugins/cpu/dynamicpolicy/policy_hint_handlers.go
Outdated
Show resolved
Hide resolved
feat(qrm): remove unused line
nightmeng
force-pushed
the
dev/support-qrm-vpa-admit
branch
4 times, most recently
from
August 20, 2024 06:19
22eca8e
to
fd505f6
Compare
csfldf
previously approved these changes
Aug 20, 2024
nightmeng
force-pushed
the
dev/support-qrm-vpa-admit
branch
from
August 20, 2024 06:28
fd505f6
to
119d784
Compare
nightmeng
changed the title
feat(qrm): support vpa admit
feat(qrm): support pod inplace update resize admit
Aug 20, 2024
xu282934741
reviewed
Aug 20, 2024
nightmeng
force-pushed
the
dev/support-qrm-vpa-admit
branch
from
August 20, 2024 08:26
119d784
to
4908830
Compare
xu282934741
approved these changes
Aug 21, 2024
csfldf
approved these changes
Aug 21, 2024
luomingmeng
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Features
What this PR does / why we need it:
Support pod inplace update resize admit.
Which issue(s) this PR fixes:
Special notes for your reviewer: