Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support clear residual net class #666

Merged

Conversation

luomingmeng
Copy link
Collaborator

What type of PR is this?

Bug fixes

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

@luomingmeng luomingmeng added bug Something isn't working workflow/need-review review: test succeeded, need to review labels Aug 1, 2024
@luomingmeng luomingmeng self-assigned this Aug 1, 2024
@luomingmeng luomingmeng marked this pull request as ready for review August 1, 2024 13:20
@luomingmeng luomingmeng requested a review from csfldf as a code owner August 1, 2024 13:20
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 59.13978% with 38 lines in your changes missing coverage. Please review.

Project coverage is 56.92%. Comparing base (7d9189e) to head (78f44b5).

Files Patch % Lines
...g/agent/qrm-plugins/network/staticpolicy/policy.go 52.83% 17 Missing and 8 partials ⚠️
pkg/metaserver/external/cgroupid/manager.go 30.76% 9 Missing ⚠️
pkg/util/external/network/manager.go 92.00% 1 Missing and 1 partial ⚠️
pkg/util/external/network/manager_linux.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #666      +/-   ##
==========================================
+ Coverage   56.90%   56.92%   +0.01%     
==========================================
  Files         554      556       +2     
  Lines       53185    53257      +72     
==========================================
+ Hits        30265    30315      +50     
- Misses      19123    19130       +7     
- Partials     3797     3812      +15     
Flag Coverage Δ
unittest 56.92% <59.13%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luomingmeng luomingmeng force-pushed the dev/clean-net-class-periodically branch 5 times, most recently from 39d12d0 to 0a95163 Compare August 1, 2024 16:34
@luomingmeng luomingmeng requested a review from caohe as a code owner August 1, 2024 17:13
@luomingmeng luomingmeng force-pushed the dev/clean-net-class-periodically branch 10 times, most recently from 7aa5a9b to 9d02aa3 Compare August 2, 2024 09:10
caohe
caohe previously approved these changes Aug 6, 2024
@luomingmeng luomingmeng merged commit 8ea7721 into kubewharf:main Aug 9, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants