feat(fragmem): unified solution for memory compaction #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubinszARM
force-pushed
the
pr_memory_compaction
branch
2 times, most recently
from
3110649 to
c60067e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #667 +/- ##
==========================================
+ Coverage 55.79% 55.91% +0.12%
==========================================
Files 573 575 +2
Lines 66840 66980 +140
==========================================
+ Hits 37294 37454 +160
+ Misses 25575 25548 -27
- Partials 3971 3978 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
lubinszARM
force-pushed
the
pr_memory_compaction
branch
7 times, most recently
from
847528c to
15f301c
Compare
lubinszARM
force-pushed
the
pr_memory_compaction
branch
from
15f301c to
6458974
Compare
lubinszARM
force-pushed
the
pr_memory_compaction
branch
6 times, most recently
from
3057fb1 to
40f218e
Compare
lubinszARM
requested review from
xu282934741 and
waynepeking348
as code owners
lubinszARM
force-pushed
the
pr_memory_compaction
branch
8 times, most recently
from
c81532d to
c51afb4
Compare
lubinszARM
force-pushed
the
pr_memory_compaction
branch
2 times, most recently
from
2dccb6b to
6f742ec
Compare
xu282934741
added
the
workflow/need-review
lubinszARM
force-pushed
the
pr_memory_compaction
branch
4 times, most recently
from
5e1a240 to
a728e12
Compare
Signed-off-by: Robin Lu <robin.lu@bytedance.com>
Signed-off-by: Robin Lu <robin.lu@bytedance.com>
lubinszARM
force-pushed
the
pr_memory_compaction
branch
from
a728e12 to
7cda1b9
Compare
luomingmeng
reviewed
Oct 23, 2024
| @@ -140,6 +140,7 @@ func (m *MalachiteMetricsProvisioner) updateSystemStats() error { | |||
| } else { | |||
| m.processSystemMemoryData(systemMemoryData) | |||
| m.processSystemNumaData(systemMemoryData) | |||
| m.processSystemNumaMemFragData(systemMemoryData) | |||
| } | |||
There was a problem hiding this comment.
rename to processSystemExtFragData?
lubinszARM
force-pushed
the
pr_memory_compaction
branch
from
7cda1b9 to
443a72c
Compare
Signed-off-by: Robin Lu <robin.lu@bytedance.com>
lubinszARM
force-pushed
the
pr_memory_compaction
branch
from
443a72c to
c364e14
Compare
luomingmeng
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Features: adding support for memory fragmentation management
What this PR does / why we need it:
In production area, memory fragmentation related issues can cause numerous problems.
Which issue(s) this PR fixes:
Many issues.
Special notes for your reviewer:
None.