Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dynamic config disable configuration and fix zone allocations out of order #67

Conversation

luomingmeng
Copy link
Collaborator

What type of PR is this?

Bug fixes

What this PR does / why we need it:

  1. add dynamic config disable configuration
  2. fix zone allocations out of order

@luomingmeng luomingmeng self-assigned this May 17, 2023
@luomingmeng luomingmeng added bug Something isn't working workflow/need-review review: test succeeded, need to review labels May 17, 2023
@luomingmeng luomingmeng added this to the v0.2 milestone May 17, 2023
@luomingmeng luomingmeng marked this pull request as ready for review May 17, 2023 05:40
@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Patch coverage: 65.37% and project coverage change: +0.26 🎉

Comparison is base (21d86d9) 51.30% compared to head (0583bb0) 51.56%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #67      +/-   ##
==========================================
+ Coverage   51.30%   51.56%   +0.26%     
==========================================
  Files         318      325       +7     
  Lines       32418    33045     +627     
==========================================
+ Hits        16632    17041     +409     
- Misses      13840    14004     +164     
- Partials     1946     2000      +54     
Flag Coverage Δ
unittest 51.56% <65.37%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/agent/qrm-plugins/cpu/dynamicpolicy/policy.go 38.32% <0.00%> (-0.03%) ⬇️
...ourcemanager/fetcher/kubelet/topology/interface.go 0.00% <0.00%> (ø)
pkg/client/control/cnr.go 37.80% <0.00%> (-1.94%) ⬇️
pkg/config/agent/global/base.go 100.00% <ø> (ø)
pkg/config/agent/global/metaserver.go 100.00% <ø> (ø)
pkg/util/general/error.go 0.00% <0.00%> (ø)
...ysadvisor/plugin/qosaware/server/cpu/cpu_server.go 54.41% <3.92%> (-1.24%) ⬇️
.../agent/resourcemanager/reporter/cnr/cnrreporter.go 61.20% <27.58%> (-3.06%) ⬇️
...md/katalyst-agent/app/options/global/metaserver.go 50.79% <33.33%> (-0.88%) ⬇️
pkg/agent/resourcemanager/reporter/converter.go 33.33% <33.33%> (ø)
... and 34 more

... and 13 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@luomingmeng luomingmeng requested a review from csfldf May 17, 2023 06:18
@luomingmeng luomingmeng added workflow/merge-ready merge-ready: code is ready and can be merged and removed workflow/need-review review: test succeeded, need to review labels May 17, 2023
@waynepeking348 waynepeking348 merged commit f42d83a into kubewharf:main May 17, 2023
luomingmeng added a commit to luomingmeng/katalyst-core that referenced this pull request Oct 11, 2024
… of order (kubewharf#67)

* support disable dynamic configuration

* merge topologyZone Attributes and Allocations in generateTopologyZoneStatus to make sure the final zone status sorted
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working workflow/merge-ready merge-ready: code is ready and can be merged
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants