-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
memory headroom canonical policy support enable buffer #68
Merged
waynepeking348
merged 1 commit into
kubewharf:main
from
luomingmeng:dev/canonical_memory_headroom_policy_support_enable_buffer
May 19, 2023
Merged
memory headroom canonical policy support enable buffer #68
waynepeking348
merged 1 commit into
kubewharf:main
from
luomingmeng:dev/canonical_memory_headroom_policy_support_enable_buffer
May 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #68 +/- ##
==========================================
+ Coverage 51.30% 51.55% +0.25%
==========================================
Files 318 330 +12
Lines 32418 33312 +894
==========================================
+ Hits 16632 17175 +543
- Misses 13840 14117 +277
- Partials 1946 2020 +74
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
luomingmeng
force-pushed
the
dev/canonical_memory_headroom_policy_support_enable_buffer
branch
2 times, most recently
from
May 18, 2023 05:07
4cf1235
to
3e13f0e
Compare
luomingmeng
added
the
workflow/need-review
review: test succeeded, need to review
label
May 18, 2023
luomingmeng
force-pushed
the
dev/canonical_memory_headroom_policy_support_enable_buffer
branch
6 times, most recently
from
May 18, 2023 11:41
18faa1a
to
fdce04b
Compare
cmd/katalyst-agent/app/options/sysadvisor/qosaware/resource/memory/headroom/policy_canonical.go
Outdated
Show resolved
Hide resolved
pkg/agent/sysadvisor/plugin/qosaware/resource/memory/headroompolicy/policy_canonical.go
Outdated
Show resolved
Hide resolved
pkg/agent/sysadvisor/plugin/qosaware/resource/memory/headroompolicy/policy_canonical.go
Outdated
Show resolved
Hide resolved
pkg/agent/sysadvisor/plugin/qosaware/resource/memory/headroompolicy/policy_canonical.go
Outdated
Show resolved
Hide resolved
pkg/agent/sysadvisor/plugin/qosaware/resource/memory/headroompolicy/policy_canonical.go
Outdated
Show resolved
Hide resolved
luomingmeng
force-pushed
the
dev/canonical_memory_headroom_policy_support_enable_buffer
branch
4 times, most recently
from
May 19, 2023 06:55
e73ddea
to
b30f177
Compare
luomingmeng
force-pushed
the
dev/canonical_memory_headroom_policy_support_enable_buffer
branch
from
May 19, 2023 07:09
b30f177
to
cf765bd
Compare
waynepeking348
approved these changes
May 19, 2023
sun-yuliang
approved these changes
May 19, 2023
luomingmeng
added
workflow/merge-ready
merge-ready: code is ready and can be merged
and removed
workflow/need-review
review: test succeeded, need to review
labels
May 19, 2023
luomingmeng
added a commit
to luomingmeng/katalyst-core
that referenced
this pull request
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
workflow/merge-ready
merge-ready: code is ready and can be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Features
What this PR does / why we need it:
Current canonical memory headroom policy only consider the memory estimation of non-reclaimed QoS container, and uses the RSS memory to estimate, which may trigger memory reclamation frequently when shared or dedicated QoS container use much more cache and shmem in high load case, so we also need consider them in memory estimation and add extra memory margin.
In the low load case, the machine has enough free memory, the extra memory margin or cache can also oversold to reclaimed QoS worklaod to increase memory utilization.