Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memory headroom canonical policy support enable buffer #68

Conversation

luomingmeng
Copy link
Collaborator

@luomingmeng luomingmeng commented May 18, 2023

What type of PR is this?

Features

What this PR does / why we need it:

Current canonical memory headroom policy only consider the memory estimation of non-reclaimed QoS container, and uses the RSS memory to estimate, which may trigger memory reclamation frequently when shared or dedicated QoS container use much more cache and shmem in high load case, so we also need consider them in memory estimation and add extra memory margin.
In the low load case, the machine has enough free memory, the extra memory margin or cache can also oversold to reclaimed QoS worklaod to increase memory utilization.

@luomingmeng luomingmeng self-assigned this May 18, 2023
@luomingmeng luomingmeng added the enhancement New feature or request label May 18, 2023
@luomingmeng luomingmeng added this to the v0.2 milestone May 18, 2023
@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Patch coverage: 65.20% and project coverage change: +0.25 🎉

Comparison is base (21d86d9) 51.30% compared to head (cf765bd) 51.55%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #68      +/-   ##
==========================================
+ Coverage   51.30%   51.55%   +0.25%     
==========================================
  Files         318      330      +12     
  Lines       32418    33312     +894     
==========================================
+ Hits        16632    17175     +543     
- Misses      13840    14117     +277     
- Partials     1946     2020      +74     
Flag Coverage Δ
unittest 51.55% <65.20%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/agent/qrm-plugins/cpu/dynamicpolicy/policy.go 38.32% <0.00%> (-0.03%) ⬇️
...ourcemanager/fetcher/kubelet/topology/interface.go 0.00% <0.00%> (ø)
...nt/sysadvisor/plugin/qosaware/reporter/reporter.go 39.00% <0.00%> (-37.55%) ⬇️
pkg/client/control/cnr.go 37.80% <0.00%> (-1.94%) ⬇️
pkg/config/agent/global/base.go 100.00% <ø> (ø)
pkg/util/general/error.go 0.00% <0.00%> (ø)
...ysadvisor/plugin/qosaware/server/cpu/cpu_server.go 54.26% <2.00%> (-1.40%) ⬇️
.../agent/resourcemanager/reporter/cnr/cnrreporter.go 61.20% <27.58%> (-3.06%) ⬇️
pkg/agent/resourcemanager/reporter/converter.go 33.33% <33.33%> (ø)
pkg/metaserver/agent/cnr/cnr_stub.go 60.00% <33.33%> (-40.00%) ⬇️
... and 41 more

... and 17 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@luomingmeng luomingmeng force-pushed the dev/canonical_memory_headroom_policy_support_enable_buffer branch 2 times, most recently from 4cf1235 to 3e13f0e Compare May 18, 2023 05:07
@luomingmeng luomingmeng added the workflow/need-review review: test succeeded, need to review label May 18, 2023
@luomingmeng luomingmeng marked this pull request as ready for review May 18, 2023 05:08
@luomingmeng luomingmeng force-pushed the dev/canonical_memory_headroom_policy_support_enable_buffer branch 6 times, most recently from 18faa1a to fdce04b Compare May 18, 2023 11:41
@luomingmeng luomingmeng force-pushed the dev/canonical_memory_headroom_policy_support_enable_buffer branch 4 times, most recently from e73ddea to b30f177 Compare May 19, 2023 06:55
@luomingmeng luomingmeng force-pushed the dev/canonical_memory_headroom_policy_support_enable_buffer branch from b30f177 to cf765bd Compare May 19, 2023 07:09
@luomingmeng luomingmeng added workflow/merge-ready merge-ready: code is ready and can be merged and removed workflow/need-review review: test succeeded, need to review labels May 19, 2023
@waynepeking348 waynepeking348 merged commit 0be9a13 into kubewharf:main May 19, 2023
luomingmeng added a commit to luomingmeng/katalyst-core that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request workflow/merge-ready merge-ready: code is ready and can be merged
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants