Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

system_cores support set specific pool #680

Conversation

luomingmeng
Copy link
Collaborator

What type of PR is this?

Enhancements

What this PR does / why we need it:

In certain situations, a pod with the system_cores QoS level should be bound to specific CPU pools, such as the reserve pool, to prevent impact on critical pools.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 62.10191% with 119 lines in your changes missing coverage. Please review.

Project coverage is 57.23%. Comparing base (7104feb) to head (098b202).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...memory/dynamicpolicy/policy_allocation_handlers.go 64.34% 29 Missing and 17 partials ⚠️
...ns/cpu/dynamicpolicy/policy_allocation_handlers.go 53.60% 35 Missing and 10 partials ⚠️
...lugins/cpu/dynamicpolicy/policy_advisor_handler.go 0.00% 11 Missing ⚠️
...agent/qrm-plugins/cpu/dynamicpolicy/state/state.go 60.00% 3 Missing and 3 partials ⚠️
...nt/qrm-plugins/memory/dynamicpolicy/state/state.go 85.18% 2 Missing and 2 partials ⚠️
pkg/agent/qrm-plugins/cpu/dynamicpolicy/policy.go 40.00% 3 Missing ⚠️
.../agent/qrm-plugins/cpu/dynamicpolicy/state/util.go 71.42% 1 Missing and 1 partial ⚠️
...ugins/memory/dynamicpolicy/policy_hint_handlers.go 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #680      +/-   ##
==========================================
+ Coverage   57.08%   57.23%   +0.15%     
==========================================
  Files         568      568              
  Lines       54760    54967     +207     
==========================================
+ Hits        31258    31459     +201     
+ Misses      19591    19562      -29     
- Partials     3911     3946      +35     
Flag Coverage Δ
unittest 57.23% <62.10%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luomingmeng luomingmeng marked this pull request as ready for review August 23, 2024 04:10
@luomingmeng luomingmeng requested a review from nightmeng as a code owner August 23, 2024 04:10
@luomingmeng luomingmeng force-pushed the dev/system-cores-support-cpu-set-pool-enhancement branch 9 times, most recently from d9daa11 to f6bef07 Compare August 27, 2024 06:13
@luomingmeng luomingmeng force-pushed the dev/system-cores-support-cpu-set-pool-enhancement branch from e90a14e to d1fab8b Compare September 2, 2024 05:55
@luomingmeng luomingmeng force-pushed the dev/system-cores-support-cpu-set-pool-enhancement branch 12 times, most recently from 56fbfa4 to e7fc5be Compare September 13, 2024 02:29
csfldf
csfldf previously approved these changes Sep 18, 2024
@luomingmeng luomingmeng force-pushed the dev/system-cores-support-cpu-set-pool-enhancement branch from e7fc5be to 098b202 Compare September 24, 2024 12:52
@luomingmeng luomingmeng merged commit f6623f4 into kubewharf:main Sep 26, 2024
11 checks passed
@luomingmeng luomingmeng added the workflow/merge-ready merge-ready: code is ready and can be merged label Sep 26, 2024
@luomingmeng luomingmeng self-assigned this Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
workflow/merge-ready merge-ready: code is ready and can be merged
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

4 participants