-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
system_cores support set specific pool #680
Merged
luomingmeng
merged 4 commits into
kubewharf:main
from
luomingmeng:dev/system-cores-support-cpu-set-pool-enhancement
Sep 26, 2024
Merged
system_cores support set specific pool #680
luomingmeng
merged 4 commits into
kubewharf:main
from
luomingmeng:dev/system-cores-support-cpu-set-pool-enhancement
Sep 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #680 +/- ##
==========================================
+ Coverage 57.08% 57.23% +0.15%
==========================================
Files 568 568
Lines 54760 54967 +207
==========================================
+ Hits 31258 31459 +201
+ Misses 19591 19562 -29
- Partials 3911 3946 +35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
luomingmeng
force-pushed
the
dev/system-cores-support-cpu-set-pool-enhancement
branch
9 times, most recently
from
August 27, 2024 06:13
d9daa11
to
f6bef07
Compare
luomingmeng
force-pushed
the
dev/system-cores-support-cpu-set-pool-enhancement
branch
from
September 2, 2024 05:55
e90a14e
to
d1fab8b
Compare
luomingmeng
force-pushed
the
dev/system-cores-support-cpu-set-pool-enhancement
branch
12 times, most recently
from
September 13, 2024 02:29
56fbfa4
to
e7fc5be
Compare
csfldf
previously approved these changes
Sep 18, 2024
…ut numa exclusive pods by default
luomingmeng
force-pushed
the
dev/system-cores-support-cpu-set-pool-enhancement
branch
from
September 24, 2024 12:52
e7fc5be
to
098b202
Compare
xu282934741
approved these changes
Sep 25, 2024
nightmeng
approved these changes
Sep 26, 2024
luomingmeng
added
the
workflow/merge-ready
merge-ready: code is ready and can be merged
label
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Enhancements
What this PR does / why we need it:
In certain situations, a pod with the system_cores QoS level should be bound to specific CPU pools, such as the reserve pool, to prevent impact on critical pools.
Which issue(s) this PR fixes:
Special notes for your reviewer: