Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(qrm): fix reclaimed cores topology hints #681

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

nightmeng
Copy link
Collaborator

What type of PR is this?

Bug fixes

What this PR does / why we need it:

Fix reclaimed cores topology hints

Which issue(s) this PR fixes:

Special notes for your reviewer:

@nightmeng nightmeng requested a review from luomingmeng as a code owner August 23, 2024 05:33
luomingmeng
luomingmeng previously approved these changes Aug 23, 2024
@nightmeng nightmeng merged commit cb9c984 into kubewharf:main Aug 23, 2024
9 checks passed
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 57.18%. Comparing base (e47e097) to head (99996fc).
Report is 8 commits behind head on main.

Files Patch % Lines
...-plugins/cpu/dynamicpolicy/policy_hint_handlers.go 66.66% 1 Missing and 1 partial ⚠️
...ugins/memory/dynamicpolicy/policy_hint_handlers.go 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #681      +/-   ##
==========================================
+ Coverage   56.79%   57.18%   +0.39%     
==========================================
  Files         558      558              
  Lines       53582    54146     +564     
==========================================
+ Hits        30431    30966     +535     
+ Misses      19319    19305      -14     
- Partials     3832     3875      +43     
Flag Coverage Δ
unittest 57.18% <66.66%> (+0.39%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants