-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor resource-recommend controller #684
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #684 +/- ##
==========================================
- Coverage 56.74% 56.03% -0.71%
==========================================
Files 552 576 +24
Lines 52626 67022 +14396
==========================================
+ Hits 29860 37557 +7697
- Misses 19014 25467 +6453
- Partials 3752 3998 +246
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pkg/controller/resource-recommend/processor/percentile/processor.go
Outdated
Show resolved
Hide resolved
pkg/controller/resource-recommend/controller/resourcerecommend_controller.go
Outdated
Show resolved
Hide resolved
pkg/controller/resource-recommend/recommender/recommenders/percentile_recommender_test.go
Outdated
Show resolved
Hide resolved
@luomingmeng Hi, I have resolved the previous review comments, rechecked the module I was responsible for, and modified all files that did not meet the go import standard I merged my previous commits into a new commit. Since it involved repository synchronization, I used |
It doesn't matter; you can also squash the changes into several commits based on features or fixes. Just keep the number of commits reasonable. |
2024GLCC task related PR summary:
What type of PR is this?
Enhancements
What this PR does / why we need it:
Refactor resourcerecommend controller, use Katalyst controller framework
Which issue(s) this PR fixes:
#593
Special notes for your reviewer: