Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log cache evict #689

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Conversation

xixi2
Copy link
Contributor

@xixi2 xixi2 commented Aug 30, 2024

What type of PR is this?

Features

What this PR does / why we need it:

add page cache eviction for log files
we do this by call fadvise to tell kernel we don't expect access in the near future.

Which issue(s) this PR fixes:

Special notes for your reviewer:

@xixi2 xixi2 changed the title add log cache evict log cache evict Aug 30, 2024
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 53.65854% with 76 lines in your changes missing coverage. Please review.

Project coverage is 56.94%. Comparing base (f423d5b) to head (ae35f7a).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...nt/qrm-plugins/memory/handlers/logcache/manager.go 67.81% 16 Missing and 12 partials ⚠️
...ns/memory/handlers/logcache/cache_evictor_linux.go 32.43% 23 Missing and 2 partials ⚠️
...md/katalyst-agent/app/options/qrm/memory_plugin.go 53.33% 14 Missing ⚠️
...g/agent/qrm-plugins/memory/dynamicpolicy/policy.go 10.00% 8 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #689      +/-   ##
==========================================
- Coverage   56.99%   56.94%   -0.06%     
==========================================
  Files         566      568       +2     
  Lines       54500    54664     +164     
==========================================
+ Hits        31061    31127      +66     
- Misses      19553    19637      +84     
- Partials     3886     3900      +14     
Flag Coverage Δ
unittest 56.94% <53.65%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cheney-lin cheney-lin added enhancement New feature or request workflow/need-review review: test succeeded, need to review labels Sep 2, 2024
xu282934741
xu282934741 previously approved these changes Sep 4, 2024
@xixi2 xixi2 force-pushed the dev/log_cache_eviction branch from c56014e to 4a754b3 Compare September 5, 2024 03:48
@xu282934741 xu282934741 merged commit 5c0c031 into kubewharf:main Sep 5, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants