-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat)pap: power aware plugin = policy advisor + power eviction plugin + power capping plugin #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gary-lgy
reviewed
Oct 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've jotted down some points for discussion. Please see individual comments for details.
cmd/katalyst-agent/app/options/sysadvisor/poweraware/power_aware_plugin.go
Outdated
Show resolved
Hide resolved
cmd/katalyst-agent/app/options/sysadvisor/poweraware/power_aware_plugin.go
Outdated
Show resolved
Hide resolved
pkg/agent/sysadvisor/plugin/poweraware/controller/controller.go
Outdated
Show resolved
Hide resolved
pkg/agent/sysadvisor/plugin/poweraware/capper/server/fanout_notifier.go
Outdated
Show resolved
Hide resolved
pkg/agent/sysadvisor/plugin/poweraware/capper/server/service.go
Outdated
Show resolved
Hide resolved
gary-lgy
reviewed
Oct 22, 2024
cmd/katalyst-agent/app/options/sysadvisor/poweraware/power_aware_plugin.go
Outdated
Show resolved
Hide resolved
pkg/agent/sysadvisor/plugin/poweraware/evictor/server/evictor_service.go
Outdated
Show resolved
Hide resolved
pkg/agent/sysadvisor/plugin/poweraware/evictor/server/evictor_service.go
Outdated
Show resolved
Hide resolved
xu282934741
reviewed
Oct 30, 2024
…the pending reset on new connection; various refactorings
5565ff6
to
404b45e
Compare
xu282934741
reviewed
Nov 1, 2024
8656c66
to
9677555
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feature: power aware plugin in sys-advisor
What this PR does / why we need it:
Which issue(s) this PR fixes:
NA
Special notes for your reviewer:
the power usage data collection part is not included yet. A locl impi reader shall be provided as temporary fillup; the ideal solution if getting power usage data from external data source like malachite.