Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat)pap: power aware plugin = policy advisor + power eviction plugin + power capping plugin #696

Merged
merged 4 commits into from
Nov 4, 2024

Conversation

h-w-chen
Copy link
Contributor

@h-w-chen h-w-chen commented Sep 9, 2024

What type of PR is this?

feature: power aware plugin in sys-advisor

What this PR does / why we need it:

  • This PR implements the policy making part(a.k.a. controller) of power aware feature.
  • It also implements the eviction plugin to facilitate the eviction manager (typical part of agent), and the power capping plugin to facilitate the power capper (residing in qrm; its implementation is not in this PR).

Which issue(s) this PR fixes:

NA

Special notes for your reviewer:

the power usage data collection part is not included yet. A locl impi reader shall be provided as temporary fillup; the ideal solution if getting power usage data from external data source like malachite.

@h-w-chen h-w-chen requested a review from nightmeng as a code owner September 9, 2024 03:11
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 52.21239% with 378 lines in your changes missing coverage. Please review.

Project coverage is 55.89%. Comparing base (99996fc) to head (9677555).
Report is 61 commits behind head on main.

Files with missing lines Patch % Lines
...advisor/plugin/poweraware/capper/server/service.go 24.60% 92 Missing and 3 partials ⚠️
...lugin/poweraware/evictor/server/evictor_service.go 37.75% 58 Missing and 3 partials ⚠️
...nt/sysadvisor/plugin/poweraware/advisor/advisor.go 41.93% 45 Missing and 9 partials ⚠️
.../agent/sysadvisor/plugin/poweraware/power_aware.go 30.76% 35 Missing and 1 partial ⚠️
...sysadvisor/plugin/poweraware/capper/instruction.go 61.64% 23 Missing and 5 partials ⚠️
...plugin/poweraware/capper/server/fanout_notifier.go 71.42% 13 Missing and 5 partials ⚠️
...kg/agent/sysadvisor/plugin/poweraware/spec/spec.go 78.48% 16 Missing and 1 partial ⚠️
...or/plugin/poweraware/evictor/percentage_evictor.go 58.97% 12 Missing and 4 partials ⚠️
...sadvisor/plugin/poweraware/capper/server/server.go 0.00% 13 Missing ⚠️
...gin/poweraware/advisor/action/strategy/strategy.go 80.95% 5 Missing and 3 partials ⚠️
... and 7 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #696      +/-   ##
==========================================
- Coverage   57.18%   55.89%   -1.30%     
==========================================
  Files         558      593      +35     
  Lines       54146    67813   +13667     
==========================================
+ Hits        30966    37907    +6941     
- Misses      19305    25868    +6563     
- Partials     3875     4038     +163     
Flag Coverage Δ
unittest 55.89% <52.21%> (-1.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@h-w-chen h-w-chen changed the title WIP: pap: power aware plugin = advisor plugin + power eviction server + power cap server (feat)pap: power aware plugin = advisor plugin + power eviction server + power cap server Sep 11, 2024
@h-w-chen h-w-chen changed the title (feat)pap: power aware plugin = advisor plugin + power eviction server + power cap server (feat)pap: power aware plugin = advisor plugin + power eviction plugin + power capping plugin Sep 11, 2024
@h-w-chen h-w-chen changed the title (feat)pap: power aware plugin = advisor plugin + power eviction plugin + power capping plugin (feat)pap: power aware plugin = policy advisor + power eviction plugin + power capping plugin Sep 11, 2024
@xu282934741 xu282934741 added the workflow/need-review review: test succeeded, need to review label Sep 19, 2024
Copy link
Member

@gary-lgy gary-lgy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've jotted down some points for discussion. Please see individual comments for details.

@xu282934741 xu282934741 merged commit 4df549f into kubewharf:main Nov 4, 2024
11 checks passed
@h-w-chen h-w-chen deleted the dev/pap-core branch January 9, 2025 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants