Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(qrm): refactor the state module for enhanced extensibility #697

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

xu282934741
Copy link
Collaborator

What type of PR is this?

What this PR does / why we need it:

if we want to add a new strategy, this refactoring will be helpful.

@CLAassistant
Copy link

CLAassistant commented Sep 11, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 86.53846% with 7 lines in your changes missing coverage. Please review.

Project coverage is 57.21%. Comparing base (fcb8f49) to head (8cbe21e).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
.../agent/qrm-plugins/cpu/dynamicpolicy/state/util.go 87.17% 3 Missing and 2 partials ⚠️
pkg/agent/qrm-plugins/cpu/dynamicpolicy/policy.go 0.00% 1 Missing ⚠️
pkg/agent/qrm-plugins/cpu/nativepolicy/policy.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #697      +/-   ##
==========================================
+ Coverage   57.09%   57.21%   +0.12%     
==========================================
  Files         568      568              
  Lines       54678    54760      +82     
==========================================
+ Hits        31217    31333     +116     
+ Misses      19553    19502      -51     
- Partials     3908     3925      +17     
Flag Coverage Δ
unittest 57.21% <86.53%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xu282934741 xu282934741 added workflow/merge-ready merge-ready: code is ready and can be merged and removed workflow/merge-ready merge-ready: code is ready and can be merged labels Sep 11, 2024
@xu282934741 xu282934741 merged commit 7104feb into kubewharf:main Sep 24, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants