Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(qrm): fix cpu admit failed caused by float ceil #704

Merged
merged 2 commits into from
Oct 12, 2024

Conversation

nightmeng
Copy link
Collaborator

What type of PR is this?

Bug fixes

What this PR does / why we need it:

Fix cpu admit failed caused by float ceil

Which issue(s) this PR fixes:

Special notes for your reviewer:

@nightmeng nightmeng requested a review from luomingmeng as a code owner October 8, 2024 08:35
@nightmeng nightmeng force-pushed the dev/fix-cpu-request branch 2 times, most recently from 73ea60c to 30f2294 Compare October 8, 2024 08:58
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 85.93750% with 9 lines in your changes missing coverage. Please review.

Project coverage is 57.23%. Comparing base (56ba904) to head (1f93cf4).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...-plugins/cpu/dynamicpolicy/policy_hint_handlers.go 90.00% 2 Missing and 1 partial ⚠️
...ugins/memory/dynamicpolicy/policy_hint_handlers.go 76.92% 2 Missing and 1 partial ⚠️
...md/katalyst-agent/app/options/qrm/memory_plugin.go 50.00% 2 Missing ⚠️
pkg/agent/qrm-plugins/util/util.go 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #704      +/-   ##
==========================================
+ Coverage   57.17%   57.23%   +0.05%     
==========================================
  Files         570      570              
  Lines       54864    54871       +7     
==========================================
+ Hits        31370    31403      +33     
+ Misses      19540    19519      -21     
+ Partials     3954     3949       -5     
Flag Coverage Δ
unittest 57.23% <85.93%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nightmeng nightmeng force-pushed the dev/fix-cpu-request branch 2 times, most recently from 843be9f to 12b9f93 Compare October 8, 2024 12:06
@nightmeng nightmeng force-pushed the dev/fix-cpu-request branch 2 times, most recently from 563f9db to 2eef2df Compare October 10, 2024 03:54
xu282934741
xu282934741 previously approved these changes Oct 11, 2024
@nightmeng nightmeng force-pushed the dev/fix-cpu-request branch 3 times, most recently from 81d0786 to 0341e77 Compare October 12, 2024 03:07
@nightmeng nightmeng force-pushed the dev/fix-cpu-request branch from 0341e77 to 4c5b8a5 Compare October 12, 2024 03:15
@nightmeng nightmeng force-pushed the dev/fix-cpu-request branch from 4c5b8a5 to 1f93cf4 Compare October 12, 2024 03:25
@luomingmeng luomingmeng merged commit fd1b8d6 into kubewharf:main Oct 12, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants