Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sockmem): keep the values in tcp_mem consistent #705

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

lubinszARM
Copy link
Contributor

What type of PR is this?

Enhancements:ensure consistency in the values of tcp_mem to reduce tcp memory pressure.

What this PR does / why we need it:

None

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 70.37037% with 8 lines in your changes missing coverage. Please review.

Project coverage is 55.94%. Comparing base (f6623f4) to head (f46dcde).
Report is 30 commits behind head on main.

Files with missing lines Patch % Lines
...m-plugins/memory/handlers/sockmem/sockmem_linux.go 70.37% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #705      +/-   ##
==========================================
- Coverage   57.14%   55.94%   -1.20%     
==========================================
  Files         568      576       +8     
  Lines       54981    67039   +12058     
==========================================
+ Hits        31419    37507    +6088     
- Misses      19625    25551    +5926     
- Partials     3937     3981      +44     
Flag Coverage Δ
unittest 55.94% <70.37%> (-1.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Robin Lu <robin.lu@bytedance.com>
@xu282934741 xu282934741 merged commit 3269ac6 into kubewharf:main Nov 6, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants