Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(qrm): fix printing of numa mem migrate container stats #710

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

gary-lgy
Copy link
Member

What type of PR is this?

Bug fix

What this PR does / why we need it:

Fix getting numa memory stats under cgroup v1.

Which issue(s) this PR fixes:

Special notes for your reviewer:

@gary-lgy gary-lgy force-pushed the gary/fix-numa-balancer-cgroupv1 branch from e4cd7fa to e2eee22 Compare October 28, 2024 10:46
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 20.68966% with 23 lines in your changes missing coverage. Please review.

Project coverage is 56.27%. Comparing base (0a3785c) to head (e2eee22).
Report is 25 commits behind head on main.

Files with missing lines Patch % Lines
...ins/memory/dynamicpolicy/policy_advisor_handler.go 0.00% 9 Missing ⚠️
pkg/util/cgroup/manager/v1/fs_linux.go 0.00% 7 Missing ⚠️
pkg/util/cgroup/manager/v2/fs_linux.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #710      +/-   ##
==========================================
+ Coverage   55.86%   56.27%   +0.40%     
==========================================
  Files         573      594      +21     
  Lines       66777    68007    +1230     
==========================================
+ Hits        37307    38268     +961     
- Misses      25489    25695     +206     
- Partials     3981     4044      +63     
Flag Coverage Δ
unittest 56.27% <20.68%> (+0.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@gary-lgy gary-lgy force-pushed the gary/fix-numa-balancer-cgroupv1 branch from 01406bc to e2eee22 Compare October 28, 2024 17:54
@luomingmeng luomingmeng merged commit 32a3253 into kubewharf:main Nov 20, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants