Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cgroup): fix memory policy build not in linux #712

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

luomingmeng
Copy link
Collaborator

What type of PR is this?

Bug fixes

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

@luomingmeng luomingmeng force-pushed the dev/fix-no-linux-build branch from 73f602d to d3cc5c5 Compare October 30, 2024 07:28
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 15 lines in your changes missing coverage. Please review.

Project coverage is 56.02%. Comparing base (c364e14) to head (d3cc5c5).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
pkg/util/cgroup/manager/memory_linux.go 72.72% 10 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #712      +/-   ##
==========================================
+ Coverage   55.91%   56.02%   +0.10%     
==========================================
  Files         575      577       +2     
  Lines       66980    67022      +42     
==========================================
+ Hits        37454    37550      +96     
+ Misses      25548    25470      -78     
- Partials     3978     4002      +24     
Flag Coverage Δ
unittest 56.02% <72.72%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luomingmeng luomingmeng self-assigned this Oct 31, 2024
@luomingmeng luomingmeng added bug Something isn't working workflow/need-review review: test succeeded, need to review labels Oct 31, 2024
@xu282934741 xu282934741 merged commit 864fca1 into kubewharf:main Nov 4, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants