-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kcc): support kcc canary update #722
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gary-lgy
requested review from
luomingmeng,
xu282934741 and
waynepeking348
as code owners
November 14, 2024 11:11
gary-lgy
changed the title
chore(dep): update katalyst-api
feat(kcc): support kcc canary update
Nov 14, 2024
gary-lgy
force-pushed
the
kcc-canary
branch
2 times, most recently
from
November 14, 2024 12:50
4f776bc
to
e658780
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #722 +/- ##
==========================================
+ Coverage 56.26% 56.30% +0.04%
==========================================
Files 598 597 -1
Lines 68033 68022 -11
==========================================
+ Hits 38277 38302 +25
+ Misses 25692 25668 -24
+ Partials 4064 4052 -12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
gary-lgy
force-pushed
the
kcc-canary
branch
3 times, most recently
from
November 19, 2024 08:14
0e4660a
to
a348d56
Compare
xu282934741
reviewed
Dec 2, 2024
xu282934741
previously approved these changes
Dec 2, 2024
luomingmeng
previously approved these changes
Dec 3, 2024
gary-lgy
dismissed stale reviews from luomingmeng and xu282934741
via
December 3, 2024 04:56
6724c57
luomingmeng
approved these changes
Dec 3, 2024
xu282934741
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Features
What this PR does / why we need it:
Support canary update for KCC targets.
Which issue(s) this PR fixes:
Special notes for your reviewer: