Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kcc): support kcc canary update #722

Merged
merged 5 commits into from
Dec 3, 2024

Conversation

gary-lgy
Copy link
Member

What type of PR is this?

Features

What this PR does / why we need it:

Support canary update for KCC targets.

Which issue(s) this PR fixes:

Special notes for your reviewer:

@gary-lgy gary-lgy changed the title chore(dep): update katalyst-api feat(kcc): support kcc canary update Nov 14, 2024
@gary-lgy gary-lgy requested a review from caohe as a code owner November 14, 2024 11:27
@gary-lgy gary-lgy force-pushed the kcc-canary branch 2 times, most recently from 4f776bc to e658780 Compare November 14, 2024 12:50
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 67.51592% with 153 lines in your changes missing coverage. Please review.

Project coverage is 56.30%. Comparing base (bcf012a) to head (584d3d0).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
pkg/controller/kcc/kcct.go 66.12% 115 Missing and 31 partials ⚠️
pkg/controller/kcc/util/kcct.go 85.18% 3 Missing and 1 partial ⚠️
pkg/controller/kcc/kcc.go 0.00% 1 Missing ⚠️
pkg/controller/kcc/target/target_handler.go 0.00% 1 Missing ⚠️
pkg/metaserver/kcc/manager.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #722      +/-   ##
==========================================
+ Coverage   56.26%   56.30%   +0.04%     
==========================================
  Files         598      597       -1     
  Lines       68033    68022      -11     
==========================================
+ Hits        38277    38302      +25     
+ Misses      25692    25668      -24     
+ Partials     4064     4052      -12     
Flag Coverage Δ
unittest 56.30% <67.51%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gary-lgy gary-lgy force-pushed the kcc-canary branch 3 times, most recently from 0e4660a to a348d56 Compare November 19, 2024 08:14
xu282934741
xu282934741 previously approved these changes Dec 2, 2024
luomingmeng
luomingmeng previously approved these changes Dec 3, 2024
@xu282934741 xu282934741 merged commit 5e4c267 into kubewharf:main Dec 3, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants