Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor qrm state #725

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Conversation

luomingmeng
Copy link
Collaborator

@luomingmeng luomingmeng commented Nov 22, 2024

What type of PR is this?

Enhancements

What this PR does / why we need it:

To enhance scalability, we are refactoring the CPU/memory plugin state in QRM to support a read-write interface for situations where asynchronous state updates are necessary.

Which issue(s) this PR fixes:

Special notes for your reviewer:

@luomingmeng luomingmeng force-pushed the dev/refactor-qrm-state branch 3 times, most recently from 7fb8667 to cb95b2e Compare November 22, 2024 09:11
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 68.96552% with 18 lines in your changes missing coverage. Please review.

Project coverage is 55.95%. Comparing base (6b0676c) to head (2fa64f4).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
...agent/qrm-plugins/cpu/dynamicpolicy/state/state.go 53.84% 12 Missing ⚠️
pkg/agent/qrm-plugins/cpu/dynamicpolicy/policy.go 0.00% 2 Missing ⚠️
pkg/agent/qrm-plugins/cpu/nativepolicy/policy.go 0.00% 2 Missing ⚠️
...nt/qrm-plugins/memory/dynamicpolicy/state/state.go 92.30% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #725   +/-   ##
=======================================
  Coverage   55.95%   55.95%           
=======================================
  Files         597      597           
  Lines       67950    67983   +33     
=======================================
+ Hits        38019    38041   +22     
- Misses      25885    25900   +15     
+ Partials     4046     4042    -4     
Flag Coverage Δ
unittest 55.95% <68.96%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luomingmeng luomingmeng force-pushed the dev/refactor-qrm-state branch from cb95b2e to 2fa64f4 Compare November 27, 2024 13:34
@xu282934741 xu282934741 merged commit 04994a5 into kubewharf:main Nov 28, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants