Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (sysadvisor): pap - fixes of defects identified in integration validation #728

Merged
merged 4 commits into from
Dec 3, 2024

Conversation

h-w-chen
Copy link
Contributor

@h-w-chen h-w-chen commented Nov 25, 2024

What type of PR is this?

Bug fixes

What this PR does / why we need it:

this PR has 3 fixes:

  1. explicit internal-op over autonomy in last 2 minutes (behavior change);
  2. power cap sock file folders creation in case it is not there;
  3. split power cap server and plugin to avoid recursive reference chain via plugin wrapper

@h-w-chen h-w-chen requested a review from gary-lgy as a code owner November 25, 2024 19:58
@h-w-chen h-w-chen changed the title pap: fixes of defects identified in integration validation fix (sysadvisor): pap - fixes of defects identified in integration validation Nov 25, 2024
@h-w-chen h-w-chen changed the title fix (sysadvisor): pap - fixes of defects identified in integration validation WIP: pap - fixes of defects identified in integration validation Nov 25, 2024
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 56.75676% with 16 lines in your changes missing coverage. Please review.

Project coverage is 56.18%. Comparing base (6273a71) to head (07840c5).
Report is 25 commits behind head on main.

Files with missing lines Patch % Lines
...lugin/poweraware/evictor/server/evictor_service.go 63.63% 11 Missing and 1 partial ⚠️
...advisor/plugin/poweraware/capper/server/service.go 0.00% 3 Missing ⚠️
.../agent/sysadvisor/plugin/poweraware/power_aware.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #728      +/-   ##
==========================================
+ Coverage   56.05%   56.18%   +0.12%     
==========================================
  Files         597      598       +1     
  Lines       67958    68035      +77     
==========================================
+ Hits        38094    38224     +130     
+ Misses      25807    25762      -45     
+ Partials     4057     4049       -8     
Flag Coverage Δ
unittest 56.18% <56.75%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@h-w-chen h-w-chen force-pushed the dev/pap-integration-bug-fix branch from 817c612 to d5f1d8f Compare November 25, 2024 22:11
@h-w-chen h-w-chen changed the title WIP: pap - fixes of defects identified in integration validation fix (sysadvisor): pap - fixes of defects identified in integration validation Nov 25, 2024
@h-w-chen h-w-chen force-pushed the dev/pap-integration-bug-fix branch 7 times, most recently from 4f91c11 to 4b90ccc Compare November 26, 2024 23:40
@h-w-chen h-w-chen force-pushed the dev/pap-integration-bug-fix branch 2 times, most recently from 8aa56b0 to 3e37fe4 Compare November 27, 2024 07:58
@h-w-chen h-w-chen force-pushed the dev/pap-integration-bug-fix branch from d4bc292 to 07840c5 Compare December 2, 2024 22:29
@xu282934741 xu282934741 merged commit e092a7c into kubewharf:main Dec 3, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants