-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix (sysadvisor): pap - fixes of defects identified in integration validation #728
Merged
xu282934741
merged 4 commits into
kubewharf:main
from
h-w-chen:dev/pap-integration-bug-fix
Dec 3, 2024
Merged
fix (sysadvisor): pap - fixes of defects identified in integration validation #728
xu282934741
merged 4 commits into
kubewharf:main
from
h-w-chen:dev/pap-integration-bug-fix
Dec 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-w-chen
changed the title
pap: fixes of defects identified in integration validation
fix (sysadvisor): pap - fixes of defects identified in integration validation
Nov 25, 2024
h-w-chen
changed the title
fix (sysadvisor): pap - fixes of defects identified in integration validation
WIP: pap - fixes of defects identified in integration validation
Nov 25, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #728 +/- ##
==========================================
+ Coverage 56.05% 56.18% +0.12%
==========================================
Files 597 598 +1
Lines 67958 68035 +77
==========================================
+ Hits 38094 38224 +130
+ Misses 25807 25762 -45
+ Partials 4057 4049 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
h-w-chen
force-pushed
the
dev/pap-integration-bug-fix
branch
from
November 25, 2024 22:11
817c612
to
d5f1d8f
Compare
h-w-chen
changed the title
WIP: pap - fixes of defects identified in integration validation
fix (sysadvisor): pap - fixes of defects identified in integration validation
Nov 25, 2024
gary-lgy
reviewed
Nov 26, 2024
pkg/agent/sysadvisor/plugin/poweraware/advisor/action/strategy/strategy.go
Outdated
Show resolved
Hide resolved
gary-lgy
reviewed
Nov 26, 2024
pkg/agent/sysadvisor/plugin/poweraware/evictor/server/evictor_service.go
Outdated
Show resolved
Hide resolved
h-w-chen
force-pushed
the
dev/pap-integration-bug-fix
branch
7 times, most recently
from
November 26, 2024 23:40
4f91c11
to
4b90ccc
Compare
gary-lgy
reviewed
Nov 27, 2024
pkg/agent/sysadvisor/plugin/poweraware/evictor/server/evictor_service.go
Show resolved
Hide resolved
h-w-chen
force-pushed
the
dev/pap-integration-bug-fix
branch
2 times, most recently
from
November 27, 2024 07:58
8aa56b0
to
3e37fe4
Compare
…tes, power cap sock file folders creation, and nominal evict service Stop method
…n; delete extraneous 2-min strategy logic
h-w-chen
force-pushed
the
dev/pap-integration-bug-fix
branch
from
December 2, 2024 22:29
d4bc292
to
07840c5
Compare
gary-lgy
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fixes
What this PR does / why we need it:
this PR has 3 fixes: