Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cgroup): add condition compile for IsCgroupPath #732

Conversation

luomingmeng
Copy link
Collaborator

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

@luomingmeng luomingmeng requested a review from gary-lgy as a code owner December 2, 2024 03:16
@luomingmeng luomingmeng self-assigned this Dec 2, 2024
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 56.26%. Comparing base (76e6c12) to head (bcf012a).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pkg/util/cgroup/manager/cgroup_linux.go 50.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #732      +/-   ##
==========================================
+ Coverage   56.22%   56.26%   +0.03%     
==========================================
  Files         597      598       +1     
  Lines       68033    68033              
==========================================
+ Hits        38252    38277      +25     
+ Misses      25714    25692      -22     
+ Partials     4067     4064       -3     
Flag Coverage Δ
unittest 56.26% <50.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luomingmeng luomingmeng merged commit f60ad7d into kubewharf:main Dec 2, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants