Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exchange round and slowdown in cpu regulator #99

Merged

Conversation

sun-yuliang
Copy link
Collaborator

What type of PR is this?

Enhancements
-->

What this PR does / why we need it:

exchange round and slowdown procedure in cpu regulator to ignore trivial ramp down of float number

Which issue(s) this PR fixes:

#85

Special notes for your reviewer:

@sun-yuliang sun-yuliang added the workflow/need-review review: test succeeded, need to review label Jun 8, 2023
@sun-yuliang sun-yuliang self-assigned this Jun 8, 2023
@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Patch coverage: 53.05% and project coverage change: +1.48 🎉

Comparison is base (21d86d9) 51.30% compared to head (042c108) 52.79%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #99      +/-   ##
==========================================
+ Coverage   51.30%   52.79%   +1.48%     
==========================================
  Files         318      354      +36     
  Lines       32418    34557    +2139     
==========================================
+ Hits        16632    18244    +1612     
- Misses      13840    14178     +338     
- Partials     1946     2135     +189     
Flag Coverage Δ
unittest 52.79% <53.05%> (+1.48%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/agent/evictionmanager/endpoint/endpoint.go 0.00% <ø> (ø)
...ins/cpu/dynamicpolicy/calculator/cpu_assignment.go 77.01% <ø> (ø)
...gins/cpu/dynamicpolicy/cpueviction/cpu_eviciton.go 0.00% <0.00%> (-63.25%) ⬇️
pkg/agent/qrm-plugins/cpu/dynamicpolicy/policy.go 43.73% <ø> (+5.38%) ⬆️
...ins/memory/dynamicpolicy/state/state_checkpoint.go 48.05% <0.00%> (ø)
...ourcemanager/fetcher/kubelet/topology/interface.go 0.00% <0.00%> (ø)
.../agent/resourcemanager/reporter/cnr/cnrreporter.go 61.20% <ø> (-3.06%) ⬇️
pkg/agent/resourcemanager/reporter/converter.go 33.33% <ø> (ø)
pkg/agent/resourcemanager/reporter/manager.go 51.37% <ø> (-6.38%) ⬇️
pkg/agent/resourcemanager/reporter/reporter.go 55.55% <ø> (ø)
... and 133 more

... and 15 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sun-yuliang sun-yuliang requested a review from cheney-lin June 8, 2023 06:14
@sun-yuliang sun-yuliang added workflow/merge-ready merge-ready: code is ready and can be merged and removed workflow/need-review review: test succeeded, need to review labels Jun 8, 2023
Copy link
Member

@cheney-lin cheney-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the benefits of this pr?

@sun-yuliang
Copy link
Collaborator Author

What are the benefits of this pr?

Under former logic, it's common that cpu requirement float number decreases a bit, i.e. same after ceil to even number, but triggers ramp down period update, resulting in ramp down too slow in some cases. After this exchange, this issue is solved.

@waynepeking348 waynepeking348 merged commit 697fb6a into kubewharf:main Jun 8, 2023
luomingmeng pushed a commit to luomingmeng/katalyst-core that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
workflow/merge-ready merge-ready: code is ready and can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants