-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exchange round and slowdown in cpu regulator #99
exchange round and slowdown in cpu regulator #99
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #99 +/- ##
==========================================
+ Coverage 51.30% 52.79% +1.48%
==========================================
Files 318 354 +36
Lines 32418 34557 +2139
==========================================
+ Hits 16632 18244 +1612
- Misses 13840 14178 +338
- Partials 1946 2135 +189
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are the benefits of this pr?
Under former logic, it's common that cpu requirement float number decreases a bit, i.e. same after ceil to even number, but triggers ramp down period update, resulting in ramp down too slow in some cases. After this exchange, this issue is solved. |
What type of PR is this?
Enhancements
-->
What this PR does / why we need it:
exchange round and slowdown procedure in cpu regulator to ignore trivial ramp down of float number
Which issue(s) this PR fixes:
#85
Special notes for your reviewer: