Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cmd&endpoints): force exit if graceful exit is blocked #19

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

divanodestiny
Copy link
Collaborator

Change-Id: Ica4c0fd4855410f45cd8f14cbb65a209562485c9

What type of PR is this?

Bug Fix

What this PR does / why we need it:

graceful exit may be blocked in some cases.
it may due to the issue of cmux

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Change-Id: Ica4c0fd4855410f45cd8f14cbb65a209562485c9
@divanodestiny
Copy link
Collaborator Author

PTAL @xuchen-xiaoying

Copy link
Member

@xuchen-xiaoying xuchen-xiaoying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@divanodestiny divanodestiny merged commit 052637f into main Nov 14, 2022
@divanodestiny divanodestiny deleted the xyc/fix-exit-block branch January 13, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants