Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No default zero bidfloor #5

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

No default zero bidfloor #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9f7ce5a
Merge branch 'master' of github.com:prebid/Prebid.js
Dec 30, 2021
00f1ee1
Merge branch 'master' of github.com:kubient/Prebid.js
Dec 30, 2021
54cf24d
Merge branch 'master' of github.com:kubient/Prebid.js
Jan 10, 2022
c264d70
Merge branch 'master' of github.com:kubient/Prebid.js
Jan 12, 2022
4fe47df
Merge branch 'master' of github.com:kubient/Prebid.js
Jan 14, 2022
ad67150
Merge branch 'master' of github.com:kubient/Prebid.js
Jan 24, 2022
7978d89
avoid sending zero bid floor if it is not defined
Jan 24, 2022
38b8fd7
do not send 0 bidfloor
Feb 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions modules/kubientBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,22 +24,23 @@ export const spec = {
return;
}
return validBidRequests.map(function (bid) {
let floor = 0.0;
let adSlot = {
bidId: bid.bidId,
zoneId: bid.params.zoneid || ''
};

if (typeof bid.getFloor === 'function') {
const mediaType = (Object.keys(bid.mediaTypes).length == 1) ? Object.keys(bid.mediaTypes)[0] : '*';
const sizes = bid.sizes || '*';
const floorInfo = bid.getFloor({currency: 'USD', mediaType: mediaType, size: sizes});
if (typeof floorInfo === 'object' && floorInfo.currency === 'USD' && !isNaN(parseFloat(floorInfo.floor))) {
floor = parseFloat(floorInfo.floor);
if (typeof floorInfo === 'object' && floorInfo.currency === 'USD') {
let floor = parseFloat(floorInfo.floor)
if (!isNaN(floor) && floor > 0) {
adSlot.floor = parseFloat(floorInfo.floor);
}
}
}

let adSlot = {
bidId: bid.bidId,
zoneId: bid.params.zoneid || '',
floor: floor || 0.0
};

if (bid.mediaTypes.banner) {
adSlot.banner = bid.mediaTypes.banner;
}
Expand Down
8 changes: 3 additions & 5 deletions test/spec/modules/kubientBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ describe('KubientAdapter', function () {
},
getFloor: function(params) {
return {
floor: 0.05,
floor: 0,
currency: 'USD'
};
},
Expand Down Expand Up @@ -127,10 +127,9 @@ describe('KubientAdapter', function () {
expect(data.uspConsent).to.exist.and.to.equal(uspConsentData);
for (let j = 0; j < data['adSlots'].length; j++) {
let adSlot = data['adSlots'][i];
expect(adSlot).to.have.all.keys('bidId', 'zoneId', 'floor', 'banner', 'schain');
expect(adSlot).to.have.all.keys('bidId', 'zoneId', 'banner', 'schain');
expect(adSlot.bidId).to.be.a('string').and.to.equal(bidBanner.bidId);
expect(adSlot.zoneId).to.be.a('string').and.to.equal(bidBanner.params.zoneid);
expect(adSlot.floor).to.be.a('number');
expect(adSlot.schain).to.be.an('object');
expect(adSlot.banner).to.be.an('object');
}
Expand Down Expand Up @@ -202,10 +201,9 @@ describe('KubientAdapter', function () {
expect(data.uspConsent).to.exist.and.to.equal(uspConsentData);
for (let j = 0; j < data['adSlots'].length; j++) {
let adSlot = data['adSlots'][i];
expect(adSlot).to.have.all.keys('bidId', 'zoneId', 'floor', 'banner', 'schain');
expect(adSlot).to.have.all.keys('bidId', 'zoneId', 'banner', 'schain');
expect(adSlot.bidId).to.be.a('string').and.to.equal(bidBanner.bidId);
expect(adSlot.zoneId).to.be.a('string').and.to.equal(bidBanner.params.zoneid);
expect(adSlot.floor).to.be.a('number');
expect(adSlot.schain).to.be.an('object');
expect(adSlot.banner).to.be.an('object');
}
Expand Down